1654745 - Stop using about:blank navigation when destroying the toolbox

Status: RESOLVED FIXED

(Core :: DOM: Navigation, task, P1)

Description

[Julian Descottes [:jdescottes]]

about:blank navigation will become more async with https://bugzilla.mozilla.org/show_bug.cgi?id=1589102

DevTools toolbox is navigating its window to about:blank during the toolbox destroy, apparently in order to cleanup the document.
The toolbox host manager also listens to the "unload" event on the toolbox's window in order to destroy itself.

If the navigation becomes more async, the "unload" will apparently be fired later than it is today and triggers test failures because the host hasn't been destroyed properly.

The goal of this bug is to discuss alternatives we could use to replace the about:blank navigation and unblock the work in Bug 1589102.

See Bug 1589102 comment 16 and Bug 1589102 comment 17 for some more context.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1654745 - Emit toolbox-unload event from toolbox close to notify the host manager

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/930eb8f70dff
Emit toolbox-unload event from toolbox close to notify the host manager r=nchevobbe,ochameau

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/930eb8f70dff