Closed Bug 1654745 Opened 3 years ago Closed 3 years ago
Stop using about:blank navigation when destroying the toolbox
(Core :: DOM: Navigation, task, P1)
(Reporter: jdescottes, Assigned: jdescottes)
47 bytes, text/x-phabricator-request
|Details | Review|
about:blank navigation will become more async with https://bugzilla.mozilla.org/show_bug.cgi?id=1589102
DevTools toolbox is navigating its window to about:blank during the toolbox destroy, apparently in order to cleanup the document.
The toolbox host manager also listens to the "unload" event on the toolbox's window in order to destroy itself.
If the navigation becomes more async, the "unload" will apparently be fired later than it is today and triggers test failures because the host hasn't been destroyed properly.
The goal of this bug is to discuss alternatives we could use to replace the about:blank navigation and unblock the work in Bug 1589102.
See Bug 1589102 comment 16 and Bug 1589102 comment 17 for some more context.
3 years ago
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/930eb8f70dff Emit toolbox-unload event from toolbox close to notify the host manager r=nchevobbe,ochameau
3 years ago
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox81: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
You need to log in before you can comment on or make changes to this bug.