1654752 - Remove usage of actorHasMethod in animation inspector

Status: RESOLVED FIXED

(DevTools :: Inspector: Animations, task, P3)

Description

[Julian Descottes [:jdescottes]]

actorHasMethod has too many pitfalls to be reliably used.

https://searchfox.org/mozilla-central/rev/dcd9c2d2bc19d96d487825eb70c2333a4d60994e/devtools/client/inspector/animation/animation.js#535

    if (typeof this.hasPausePlaySome === "undefined") {
      this.hasPausePlaySome = await this.inspector.currentTarget.actorHasMethod(
        "animations",
        "pauseSome"
      );
    }

We should update the animation inspector to use traits instead of actorHasMethod.
However, it looks like this check was introduced for backward compatibility and can probably be simply removed. "pauseSome" should be defined on all animations actors.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1654752 - [devtools] Remove actorHasMethod usage in animation inspector

The related backward compatibility code was only to support FF62 or older and can be removed.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/34a37fea0d4f
[devtools] Remove actorHasMethod usage in animation inspector r=daisuke

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/34a37fea0d4f