1654787 - Support the --disable-pinch command line option

Status: RESOLVED FIXED

(Core :: Panning and Zooming, enhancement, P3)

Description

[Alexandre Folle de Menezes]

I have an application that runs in --kiosk mode on an unattended kiosk. My problem is that some users are pinch-zooming the app (probably by mistake), and it remains zoomed until someone goes there to fix it.
I suggest you add an equivalent to Chrome's --disable-pinch command line option. And even enable it by default with --kiosk.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Panning and Zooming' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Timothy Nikkel (:tnikkel)]

This was filed before we have smooth pinch zooming, so this was filed about reflow zooming.

Comment 3

[Timothy Nikkel (:tnikkel)]

Although not a command line, can you try setting mousewheel.with_control.action = 0 and apz.allow_zooming = false? That should fix what you describe. (It will also disable zooming when using the mouse wheel + ctrl key if that matters to you.)

Comment 4

[Alexandre Folle de Menezes]

Yes, this would work. As did my workaround of disabling multi-touch on the driver. But this issue is not about a workaround, it is about feature parity. Chrome has a useful command line option that I believe Firefox should have too.

Comment 5

[Timothy Nikkel (:tnikkel)]

Controlling it via prefs is not a work around any more than having a command line option is a work around. In fact controlling it via prefs has many advantages over a command line option, you don't have to pass the command line every time for one.

Comment 6

[Mike Kaply [:mkaply]]

Controlling it via prefs is not a work around any more than having a command line option is a work around.

I don't understand this statement. What other option is there?

If you're already passing a kiosk parameter, you can pass a disable-pinch parameter.

Comment 7

[Timothy Nikkel (:tnikkel)]

(In reply to Mike Kaply [:mkaply] from comment #6)

Controlling it via prefs is not a work around any more than having a command line option is a work around.

I don't understand this statement. What other option is there?

Comment 4 said that using prefs to resolve this issue is a work around. I am saying that using prefs are no more of a work around then having a command line option. They are both ways to change Firefox's behaviour to get what you want. So if one is a work around the other is a work around as well.

Comment 8

[Alexandre Folle de Menezes]

In my specific case, I have infrastructure in place to distribute updated startup scripts with new command line options to all of hundreds of kiosks. I would have to change browser configuration by hand on each one.

Comment 9

[Botond Ballo [:botond]]

Mike, you mentioned you might be interested in implementing this. Please feel free to move it to a better component if you'd like. I'm happy to help with getting APZ pinching to respect this option.

Comment 10

[Mike Kaply [:mkaply]]

Yeah, it's on my list. I'm thinking we add a pref explicitly around pinch zooming and then control with the command line param.

Comment 12

[Mike Kaply [:mkaply]]

Attachment: Bug 1654787 - Allow disabling pinching from the command line. r?botond

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a675665b9a84
Allow disabling pinching from the command line. r=botond

Comment 14

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/a675665b9a84

Comment 15

[Mike Kaply [:mkaply]]

Comment on attachment 9272387 [details]
Bug 1654787 - Allow disabling pinching from the command line. r?botond

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Parity with Firefox 101
• User impact if declined: No disable pinch feature
• Fix Landed on Version: 101
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Sets some prefs based on command line.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9272387 [details]
Bug 1654787 - Allow disabling pinching from the command line. r?botond

Doesn't change any default behaviors but allows better lockdown in restricted environments. Approved for 91.10esr.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr91/rev/a074f080d4a5