Closed Bug 1654814 Opened 6 months ago Closed 5 months ago

Increase margin-top to subtitle in about:welcome page

Categories

(Firefox :: Messaging System, defect, P1)

defect

Tracking

()

VERIFIED FIXED
81 Branch
Iteration:
81.1 - July 27 - Aug 09
Tracking Status
firefox80 + verified
firefox81 --- verified

People

(Reporter: petercpg, Assigned: pdahiya)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

In about:welcome page, there is a subtitle onboarding-multistage-*-subtitle which is 0 margin-top to the header and zap line.

The margin-top is too small that made it doesn't look well, at least on my zh-TW Nightly.

I'm proposing to increase the margin-top to 12px or an appropriate value (see screenshot)

We have bug 1651810 opened to optimize description text and zap placement by OS. This bug is specific to increasing spacing between title and subtitle irrespective of Zap. NI Aaron to get UX take on fixing this by increasing margin between title and subtitle which can be a quick fix and simpler uplift in 80. Thanks

Flags: needinfo?(abenson)

This looks good to me!

Flags: needinfo?(abenson)
Assignee: nobody → pdahiya
Iteration: --- → 81.1 - July 27 - Aug 09
Priority: -- → P1

The severity field is not set for this bug.
:tspurway, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(tspurway)
Severity: -- → S3
Flags: needinfo?(tspurway)
Pushed by pdahiya@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/aec28efaf7e9
Increase margin-top to subtitle in about:welcome page r=emcminn

[Tracking Requested - why for this release]:
CSS fix to help display welcome screen subtitle spaced better with localized text such as TW region. Thanks

Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (81.0a1 Build ID - 20200811091731) installed, on Windows 10 x64, Ubuntu 18.04 x64 and Mac 10.15. Now, the "margin-top" value of the "about:welcome" page subtitle was set to "10px".

Status: RESOLVED → VERIFIED

Comment on attachment 9168973 [details]
Bug 1654814 - Increase margin-top to subtitle in about:welcome page

Beta/Release Uplift Approval Request

  • User impact if declined: Help display welcome screen subtitle spaced better with localized text such as TW region
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: https://bugzilla.mozilla.org/show_bug.cgi?id=1654814#c10
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Small CSS patch that add space between title and subtitle text
  • String changes made/needed: None
Attachment #9168973 - Flags: approval-mozilla-beta?
Flags: qe-verify+

Comment on attachment 9168973 [details]
Bug 1654814 - Increase margin-top to subtitle in about:welcome page

about:welcome css fix, approved for 80.0b8

Attachment #9168973 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-triaged]

I have verified that this issue is no longer reproducible with the latest Firefox Beta (80.0b8 Build ID - 20200813191622) installed, on Windows 10 x64, Ubuntu 18.04 x64 and Mac 10.15. Now, the "margin-top" value of the "about:welcome" page subtitle was set to "10px".

Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.