1654814 - Increase margin-top to subtitle in about:welcome page

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Peter Pin-Guang Chen [:petercpg] (MozTW.org)]

In about:welcome page, there is a subtitle onboarding-multistage-*-subtitle which is 0 margin-top to the header and zap line.

The margin-top is too small that made it doesn't look well, at least on my zh-TW Nightly.

I'm proposing to increase the margin-top to 12px or an appropriate value (see screenshot)

Comment 1

[Peter Pin-Guang Chen [:petercpg] (MozTW.org)]

Attachment: Current, margin-top = 0

Comment 2

[Peter Pin-Guang Chen [:petercpg] (MozTW.org)]

Attachment: Mock up - margin-top: 12px

Comment 3

[Punam Dahiya [:pdahiya]]

We have bug 1651810 opened to optimize description text and zap placement by OS. This bug is specific to increasing spacing between title and subtitle irrespective of Zap. NI Aaron to get UX take on fixing this by increasing margin between title and subtitle which can be a quick fix and simpler uplift in 80. Thanks

Comment 4

[Aaron Benson]

This looks good to me!

Comment 5

[Punam Dahiya [:pdahiya]]

Attachment: Bug 1654814 - Increase margin-top to subtitle in about:welcome page

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:tspurway, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aec28efaf7e9
Increase margin-top to subtitle in about:welcome page r=emcminn

Comment 8

[Punam Dahiya [:pdahiya]]

[Tracking Requested - why for this release]:
CSS fix to help display welcome screen subtitle spaced better with localized text such as TW region. Thanks

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/aec28efaf7e9

Comment 10

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (81.0a1 Build ID - 20200811091731) installed, on Windows 10 x64, Ubuntu 18.04 x64 and Mac 10.15. Now, the "margin-top" value of the "about:welcome" page subtitle was set to "10px".

Comment 11

[Punam Dahiya [:pdahiya]]

Comment on attachment 9168973 [details]
Bug 1654814 - Increase margin-top to subtitle in about:welcome page

Beta/Release Uplift Approval Request

• User impact if declined: Help display welcome screen subtitle spaced better with localized text such as TW region
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: https://bugzilla.mozilla.org/show_bug.cgi?id=1654814#c10
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small CSS patch that add space between title and subtitle text
• String changes made/needed: None

Comment 12

[Julien Cristau [:jcristau]]

Comment on attachment 9168973 [details]
Bug 1654814 - Increase margin-top to subtitle in about:welcome page

about:welcome css fix, approved for 80.0b8

Comment 13

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/dedb5102450d

Comment 14

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Beta (80.0b8 Build ID - 20200813191622) installed, on Windows 10 x64, Ubuntu 18.04 x64 and Mac 10.15. Now, the "margin-top" value of the "about:welcome" page subtitle was set to "10px".