1654851 - Ensure Private Fields are preserved through transplatation

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

Private fields should be preserved when an object is transplanted.

Comment 1

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1654851 - Correctly handle transplanting objects with private fields r?jorendorff

As part of DOM node adoption they are transplanted, and their expando chains are copied over.

This copying uses JS_CopyPropertiesFrom, which until this patch, cannot see
private fields as they are excluded from property iteration. This patch adds
property iteration for private fields, and renames JS_CopyPropertiesFrom to
JS_CopyOwnPropertiesAndPrivateFields which is more accurate.

The users of this method are all doing object manipulation in ways where
preserving the copied private field is the better default.

In addition to testing DOM nodes explicitly, this patch also adds a jit-test
which uses transplantableObject to test similar things with FakeDOMObjects.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eda366bce802
Correctly handle transplanting objects with private fields r=jorendorff,extension-reviewers,zombie

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e67d65bd08a4
Fix eslint prettier failures. a=lint-fix

Comment 4

[Alexandru Michis [:malexandru]]

Made a quick fix for the eslint failures seen here:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=312762510&repo=autoland&lineNumber=508

These were "prettier" issues so they were fixed by running the lint tool on the file.

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/eda366bce802
https://hg.mozilla.org/mozilla-central/rev/e67d65bd08a4