1654852 - mozregression fails to start GVE on rooted pixel2 device

Status: RESOLVED MOVED

(Testing :: mozregression, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

$ ./mach mozregression -n gve --persist ~/Downloads/mozregression/ --pref gfx.webrender.all:true --launch 2020-06-17 
Traceback (most recent call last):
  File "/home/kats/zspace/gecko-mobile/obj-android-x86_64-debugopt/_virtualenvs/init_py3/lib/python3.6/site-packages/glean/_subprocess/_process_dispatcher_helper.py", line 36, in <module>
    success = func(*args)
TypeError: _process() takes 2 positional arguments but 3 were given
 0:01.53 INFO: Using local file: /home/kats/Downloads/mozregression/fa0afb432810--mozilla-central--arm--geckoview_example.apk
 0:01.53 INFO: Running mozilla-central build built on 2020-06-17 22:42:07.985000, revision fa0afb43
 0:01.55 WARNING: Unable to find application.ini
 0:01.55 WARNING: Unable to find platform.ini
 0:01.56 INFO: Using adb 1.0.41
 0:02.09 INFO: adbd not restarted as root
 0:02.70 INFO: su -c setenforce 0 exitcode 0, stdout: None
 0:03.01 INFO: /system/bin/ls -1A supported
 0:03.12 INFO: Native cp support: True
 0:03.22 INFO: Native chmod -R support: True
 0:03.33 INFO: Native chown -R support: True
 0:03.43 INFO: Ignoring attempt to set SELinux Permissive.
 0:03.54 INFO: Native pidof support: True
 0:12.63 ERROR: Unable to start the application (error: Can not run command chmod -R 777 /data/local/tmp/tests as root!)
 0:12.63 ERROR: Unable to start the application (error: Can not run command chmod -R 777 /data/local/tmp/tests as root!)

Comment 1

[William Lachance (:wlach)]

Can you try downgrading to mozdevice 3.1.0 and see if it helps (would probably need to use a standalone build of mozregression)? This feels like it might be a variant of bug 1644327

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Yes, downgrading to mozdevice 3.1.0 fixes the problem. mozdevice 3.2.3 (which is what ends up in a fresh mozregression virtualenv using the instructions in README.md) gave me the same error.

Comment 3

[William Lachance (:wlach)]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #2)

Yes, downgrading to mozdevice 3.1.0 fixes the problem. mozdevice 3.2.3 (which is what ends up in a fresh mozregression virtualenv using the instructions in README.md) gave me the same error.

Currently 3.1.0 is what's in the requirements files, so it's what should be installed if you follow the instructions literally.

I feel like this should somehow be resolved by bug 1486004 and mozdevice 4.0.0 being released to pypi (there is also a PR which we need to land here: https://github.com/mozilla/mozregression/pull/684/files). I am guessing :bc will take care of this when he returns? I will make a point of checking in with him next week.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

(In reply to William Lachance (:wlach) (use needinfo!) from comment #3)

Currently 3.1.0 is what's in the requirements files, so it's what should be installed if you follow the instructions literally.

The pip install -e . step from the README apparently replaced 3.1.0 (from the requirements file) with 3.2.3 (from setup.py).

But yes, presumably mozdevice 4.0.0 and the PR will fix this. Thanks!

Comment 5

[Kartikaya Gupta (email:[e-mail])]

I tested the PR and it does fix this issue, so I'll close this in favour of that.