1654984 - Since bug 1593467, needless error reports about non-existing logins-backup.json

Status: RESOLVED FIXED

(Toolkit :: Password Manager, defect, P2)

Description

[Magnus Melin [:mkmelin]]

+++ This bug was initially created as a clone of Bug #1593467 +++

Due to https://hg.mozilla.org/mozilla-central/rev/8754a74ef0f8392812458246b61756096e0f35cb there's is needlessly errors reported to the console, causing some Thunderbird tests to fail (because the tests are watching for console errors). https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=310884841&repo=comm-central&lineNumber=4372

Fails:
comm/mailnews/compose/test/unit/test_autoReply.js
comm/mailnews/compose/test/unit/test_sendMessageLater2.js

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: Bug 1654984 - don't output needless error reports about non-existing logins-backup.json. r?MattN

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8e3ebf0c6b3e
don't output needless error reports about non-existing logins-backup.json. r=MattN

Comment 3

[Cristina Coroiu [:ccoroiu]]

Backed out changeset 8e3ebf0c6b3e (bug 1654984) for xpcshell failures at devtools/server/tests/xpcshell/test_addons_actor.js

Backout: https://hg.mozilla.org/integration/autoland/rev/f34ad6b8f74b919b55fa3abb43dbe347d24483a8

Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=8e3ebf0c6b3eca04b1626c5c23e3057955709534

Failure logs:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=310923398&repo=autoland&lineNumber=6567
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=310923397&repo=autoland&lineNumber=10200

Comment 4

[Andreea Pavel [:apavel]]

Also caused browser chrome failures https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=310925118&repo=autoland&lineNumber=3261

Comment 5

[Magnus Melin [:mkmelin]]

Yeah, shouldn't try to create a file with undefined as the path...

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1593467

Comment 7

[Magnus Melin [:mkmelin]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f1d16b09b631bf938703ec1ca7ec6f8df926edac

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4029dc1e969b
don't output needless error reports about non-existing logins-backup.json. r=MattN

Comment 9

[Natalia Csoregi [:nataliaCs]]

Backed out for failures on browser_startup_mainthreadio.js

backout: https://hg.mozilla.org/integration/autoland/rev/01d9cd9b15a5bb57416d12983db7ae643f52f724

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=windows%2C7%2Cshippable%2Copt%2Cmochitests%2Ctest-windows7-32-shippable%2Fopt-mochitest-browser-chrome-e10s%2Cbc5&revision=4029dc1e969be2db3fd21b3867776a725de332a4

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=311004296&repo=autoland&lineNumber=1800

[task 2020-07-24T21:14:07.527Z] 21:14:07 INFO - (PoisonIOInterposer) stat - C:\Users\task_1595623200\AppData\Local\Temp\tmplcf1sq.mozrunner\key4.db-journal
[task 2020-07-24T21:14:07.527Z] 21:14:07 INFO - (PoisonIOInterposer) stat - C:\Users\task_1595623200\AppData\Local\Temp\tmplcf1sq.mozrunner\key4.db-wal
[task 2020-07-24T21:14:07.527Z] 21:14:07 INFO - Buffered messages finished
[task 2020-07-24T21:14:07.527Z] 21:14:07 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_startup_mainthreadio.js | unexpected stat on C:\Users\task_1595623200\AppData\Local\Temp\tmplcf1sq.mozrunner\logins-backup.json before becoming idle -
[task 2020-07-24T21:14:07.527Z] 21:14:07 INFO - Stack trace:
[task 2020-07-24T21:14:07.527Z] 21:14:07 INFO - nsLocalFile::ResolveAndStat
[task 2020-07-24T21:14:07.527Z] 21:14:07 INFO - InterpretGeneratorResume (self-hosted:1478:33)
[task 2020-07-24T21:14:07.527Z] 21:14:07 INFO - AsyncFunctionThrow (self-hosted:688:27)
[task 2020-07-24T21:14:07.528Z] 21:14:07 INFO - promise callback
[task 2020-07-24T21:14:07.528Z] 21:14:07 INFO - XREMain::XRE_main
[task 2020-07-24T21:14:07.528Z] 21:14:07 INFO - (PoisonIOInterposer) stat - C:\Users\task_1595623200\AppData\Local\Temp\tmplcf1sq.mozrunner\logins-backup.json
[task 2020-07-24T21:14:07.528Z] 21:14:07 INFO - (PoisonIOInterposer) stat - C:\Users\task_1595623200\AppData\Local\Temp\tmplcf1sq.mozrunner\key4.db-journal
[task 2020-07-24T21:14:07.528Z] 21:14:07 INFO - (PoisonIOInterposer) stat - C:\Users\task_1595623200\AppData\Local\Temp\tmplcf1sq.mozrunner\key4.db-wal

Comment 10

[Magnus Melin [:mkmelin]]

I think the expected stat numbers needs to be adjusted, in https://searchfox.org/comm-central/source/mozilla/browser/base/content/test/performance/browser_startup_mainthreadio.js

Geoff, can you finish this off. I'm mostly afk for a while

Comment 11

[Intermittent Failures Robot]

7 failures in 4310 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 7

Platform breakdown:

• linux64: 3
• linux64-shippable: 2
• macosx1014-64: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1654984&startday=2020-07-20&endday=2020-07-26&tree=all

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d5f388bf0798
don't output needless error reports about non-existing logins-backup.json. r=MattN

Comment 13

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/d5f388bf0798