Closed Bug 1655051 Opened 1 year ago Closed 1 year ago

Remove browser.topsites.default in favor of browser.newtabpage.activity-stream.default.sites

Categories

(Firefox :: Top Sites, task, P2)

task
Points:
2

Tracking

()

RESOLVED FIXED
82 Branch
Iteration:
82.1 - Aug 24 - Sep 6
Tracking Status
firefox81 --- fixed
firefox82 --- fixed

People

(Reporter: dao, Assigned: dao)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

browser.newtabpage.activity-stream.default.sites is established for enterprise policies, and it's probably best to carry that over. I introduced browser.topsites.default temporarily in bug 1653932 because ActivityStream.jsm sets browser.newtabpage.activity-stream.default.sites to the old geo-based default which we don't want.

Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Iteration: --- → 82.1 - Aug 24 - Sep 6
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/23bdc8b99722
Remove browser.topsites.default in favor of browser.newtabpage.activity-stream.default.sites. r=mkaply
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch

Comment on attachment 9172222 [details]
Bug 1655051 - Remove browser.topsites.default in favor of browser.newtabpage.activity-stream.default.sites. r=mkaply

Beta/Release Uplift Approval Request

  • User impact if declined: See comment 0. This is needed for moving top sites to remote settings in Firefox 81.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce: This is covered by QA's test plan.
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): The whole feature is currently disabled by default.
  • String changes made/needed:
Attachment #9172222 - Flags: approval-mozilla-beta?

Comment on attachment 9172222 [details]
Bug 1655051 - Remove browser.topsites.default in favor of browser.newtabpage.activity-stream.default.sites. r=mkaply

approved for 81.0b3

Attachment #9172222 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.