Closed Bug 1655113 Opened 4 years ago Closed 4 years ago

Allow online searching for OpenPGP keys from Key Manager

Categories

(MailNews Core :: Security: OpenPGP, enhancement)

enhancement

Tracking

(thunderbird_esr78 fixed, thunderbird79 fixed)

RESOLVED FIXED
Thunderbird 80.0
Tracking Status
thunderbird_esr78 --- fixed
thunderbird79 --- fixed

People

(Reporter: KaiE, Assigned: KaiE)

Details

Attachments

(1 file, 2 obsolete files)

Allow online searching for OpenPGP keys from Key Manager

Attached patch D84851.diff (obsolete) — Splinter Review
Attachment #9166021 - Flags: review?(alessandro)

Notes on the patch:

keyLookupHelper just a drive-by cleanup, some scenarios did not call the whendonecb

uidHelper - only moved that regexp match to separate function, no change

EnigInitCommon was no longer necessary

prompting in enigmailSearchKey copied from the import-from-url

Comment on attachment 9166021 [details] [diff] [review]
D84851.diff

Review of attachment 9166021 [details] [diff] [review]:
-----------------------------------------------------------------

I'd say this is good and adds the barebone functionality, which it works.

If possible, we should add a little text feedback for the user while searching, something like "Searching, please wait...", because the response time might vary and the user might close the dialog.
Can we show/hide that string to the right of the search field?
Attachment #9166021 - Flags: review?(alessandro) → review+

(In reply to Alessandro Castellani (:aleca) from comment #4)

If possible, we should add a little text feedback for the user while
searching, something like "Searching, please wait...", because the response
time might vary and the user might close the dialog.
Can we show/hide that string to the right of the search field?

We can't easily, because we're currently using the prompt service.
We'd need to implement our own dialog.

I will add that string, so we have it available, and can add the progress later.

Attachment #9165967 - Attachment is obsolete: true

added the extra progress string for later. carrying forward r=aleca

Attachment #9166021 - Attachment is obsolete: true
Attachment #9166028 - Flags: review+

Pushed by kaie@kuix.de:
https://hg.mozilla.org/comm-central/rev/3f083dac94ef
Allow online searching for OpenPGP keys from Key Manager. r=aleca

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Comment on attachment 9166028 [details] [diff] [review]
1655113-extra-string.patch

Allow users to discover OpenPGP keys on a WKD server or on a keyserver, important usability feature.
Attachment #9166028 - Flags: approval-comm-esr78?
Attachment #9166028 - Flags: approval-comm-beta?

received a=wsmwk for both comm-beta and comm-esr78 on Matrix

Target Milestone: --- → Thunderbird 80.0
Comment on attachment 9166028 [details] [diff] [review]
1655113-extra-string.patch

Per previous comment Approved for esr78, and beta 79.0b3
(and already landed)
Attachment #9166028 - Flags: approval-comm-esr78?
Attachment #9166028 - Flags: approval-comm-esr78+
Attachment #9166028 - Flags: approval-comm-beta?
Attachment #9166028 - Flags: approval-comm-beta+

I have a few questions regarding the functionality of this feature:
Will it be possible to specify a custom keyserver that is used for this search? This should be fairly easy to implement via a pref.
Is the search only for the discovery and import of new keys or will it be possible to refresh/sync a whole keyring? Especially for revoked keys, this use case should be considered.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: