Allow online searching for OpenPGP keys from Key Manager
Categories
(MailNews Core :: Security: OpenPGP, enhancement)
Tracking
(thunderbird_esr78 fixed, thunderbird79 fixed)
People
(Reporter: KaiE, Assigned: KaiE)
Details
Attachments
(1 file, 2 obsolete files)
10.93 KB,
patch
|
KaiE
:
review+
wsmwk
:
approval-comm-beta+
wsmwk
:
approval-comm-esr78+
|
Details | Diff | Splinter Review |
Allow online searching for OpenPGP keys from Key Manager
Assignee | ||
Comment 1•4 years ago
|
||
Assignee | ||
Comment 2•4 years ago
|
||
Assignee | ||
Comment 3•4 years ago
|
||
Notes on the patch:
keyLookupHelper just a drive-by cleanup, some scenarios did not call the whendonecb
uidHelper - only moved that regexp match to separate function, no change
EnigInitCommon was no longer necessary
prompting in enigmailSearchKey copied from the import-from-url
Comment 4•4 years ago
|
||
Comment on attachment 9166021 [details] [diff] [review] D84851.diff Review of attachment 9166021 [details] [diff] [review]: ----------------------------------------------------------------- I'd say this is good and adds the barebone functionality, which it works. If possible, we should add a little text feedback for the user while searching, something like "Searching, please wait...", because the response time might vary and the user might close the dialog. Can we show/hide that string to the right of the search field?
Assignee | ||
Comment 5•4 years ago
|
||
(In reply to Alessandro Castellani (:aleca) from comment #4)
If possible, we should add a little text feedback for the user while
searching, something like "Searching, please wait...", because the response
time might vary and the user might close the dialog.
Can we show/hide that string to the right of the search field?
We can't easily, because we're currently using the prompt service.
We'd need to implement our own dialog.
I will add that string, so we have it available, and can add the progress later.
Updated•4 years ago
|
Assignee | ||
Comment 6•4 years ago
|
||
added the extra progress string for later. carrying forward r=aleca
Pushed by kaie@kuix.de:
https://hg.mozilla.org/comm-central/rev/3f083dac94ef
Allow online searching for OpenPGP keys from Key Manager. r=aleca
Assignee | ||
Comment 8•4 years ago
|
||
Comment on attachment 9166028 [details] [diff] [review] 1655113-extra-string.patch Allow users to discover OpenPGP keys on a WKD server or on a keyserver, important usability feature.
Assignee | ||
Comment 9•4 years ago
|
||
received a=wsmwk for both comm-beta and comm-esr78 on Matrix
Assignee | ||
Comment 10•4 years ago
|
||
https://hg.mozilla.org/releases/comm-beta/rev/9c1f818286592beb906029be866199cd3a7724af
https://hg.mozilla.org/releases/comm-esr78/rev/2788cbad01a75440f06d32e667f4f99bd6202ccc
Updated•4 years ago
|
Comment 11•4 years ago
|
||
Comment on attachment 9166028 [details] [diff] [review] 1655113-extra-string.patch Per previous comment Approved for esr78, and beta 79.0b3 (and already landed)
Comment 12•4 years ago
|
||
I have a few questions regarding the functionality of this feature:
Will it be possible to specify a custom keyserver that is used for this search? This should be fairly easy to implement via a pref.
Is the search only for the discovery and import of new keys or will it be possible to refresh/sync a whole keyring? Especially for revoked keys, this use case should be considered.
Description
•