1655132 - warning: comm/mailnews/imap/src/nsImapProtocol.cpp:1829:16 [-Wformat=] format ‘%x’ expects argument of type ‘unsigned int’, but argument 4 has type ‘nsresult’

Status: RESOLVED FIXED

(MailNews Core :: Networking: IMAP, defect)

Description

[:aceman]

I get a few warnings in IMAP code compiling with GCC9.3:
28:29.57 warning: comm/mailnews/imap/src/nsImapProtocol.cpp:1829:16 [-Wformat=] format ‘%x’ expects argument of type ‘unsigned int’, but argument 4 has type ‘nsresult’
28:29.57 warning: comm/mailnews/imap/src/nsImapProtocol.cpp:4740:14 [-Wformat=] format ‘%x’ expects argument of type ‘unsigned int’, but argument 4 has type ‘nsresult’
28:29.57 warning: comm/mailnews/imap/src/nsImapProtocol.cpp:4814:35 [-Wformat=] format ‘%x’ expects argument of type ‘unsigned int’, but argument 4 has type ‘nsresult’

They do not prevent build yet (seems warnings-as-errors is currently disabled), but we should fix this preventively.

Comment 1

[ISHIKAWA, Chiaki]

I see this also locally.

Comment 2

[:aceman]

Attachment: 1655132.patch

This is how we print a nsresult, using PRIx32 and static_cast<uint32_t>, as can be seen elsewhere in the file.

Comment 3

[Magnus Melin [:mkmelin]]

Comment on attachment 9166079 [details] [diff] [review]
1655132.patch

Review of attachment 9166079 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin

Comment 4

[ISHIKAWA, Chiaki]

(In reply to :aceman from comment #2)

Created attachment 9166079 [details] [diff] [review]
1655132.patch

This is how we print a nsresult, using PRIx32 and static_cast<uint32_t>, as can be seen elsewhere in the file.

This is how I would have fixed the formatting issue. (I have fixed the printing of nsresult values using this idiom in my local patches.)

Comment 5

[ISHIKAWA, Chiaki]

Comment on attachment 9166079 [details] [diff] [review]
1655132.patch

I could compile the C-C TB with aceman's patch (instead of my local patch), too.
I am using GCC-9 under linux.

Comment 6

[:aceman]

Thanks.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ccbde15888d0
printf nsresult using PRIx32 and static_cast in a few places in nsImapProtocol.cpp. r=mkmelin