1655237 - AsyncPanZoomController::HandleDragEvent wrongly clears the state for all mouse ups

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect)

Description

[Timothy Nikkel (:tnikkel)]

AsyncPanZoomController::HandleDragEvent calls SetState(NOTHING) for every mouse up event. So if a user clicks on a scrollbar track (but not the thumb) we start a smooth scroll animation and set the state as smooth scroll to do the page scroll, but when we receive the mouse up we clear the state even though the animation still proceeds (in most cases the animation still runs to completion fine).

Comment 1

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1655237. In AsyncPanZoomController::HandleDragEvent only clear the state on mouse ups if we were in the scrolbar dragging state. r?kats,botond

If a user clicks on a scrollbar track (but not the thumb) we start a smooth scroll animation and set the state as smooth scroll to do the page scroll, but when we receive the mouse up we clear the state even though the animation still proceeds (in most cases the animation still runs to completion fine).

Depends on D84902

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2964ee0c4371
In AsyncPanZoomController::HandleDragEvent only clear the state on mouse ups if we were in the scrolbar dragging state. r=botond

Comment 3

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/2964ee0c4371