1655266 - [Linux] Firefox is not moved to workspaces after restart on Gnome shell with static workspace setup

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Martin Stránský [:stransky] (ni? me)]

This is a minor regression from Bug 1645776. Firefox is not moved to workspaces after browser restart on Gnome shell with non-default static workspace setup.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1655266 [Linux] Remove shadowed local variable 'usesDynamicWorkspaces' to correctly return worspace setup, r?rmader

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7134225dde7d
[Linux] Remove shadowed local variable 'usesDynamicWorkspaces' to correctly return worspace setup, r=rmader

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/7134225dde7d

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Is this something we should consider for Beta uplift? Please nominate if so.

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 9166077 [details]
Bug 1655266 [Linux] Remove shadowed local variable 'usesDynamicWorkspaces' to correctly return worspace setup, r?rmader

Beta/Release Uplift Approval Request

• User impact if declined: Users with fixed workspace setup on Gnone won't get restored Firefox windows on particular workspaces but all Firefox will be resotred at first workspace.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The fix removes unused local variable which shadowed an actual one, as it was before.
• String changes made/needed:

Comment 6

[Julien Cristau [:jcristau]]

Comment on attachment 9166077 [details]
Bug 1655266 [Linux] Remove shadowed local variable 'usesDynamicWorkspaces' to correctly return worspace setup, r?rmader

approved for 80.0b6

Comment 7

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/5c21c5ae3394