Closed Bug 1655283 Opened 3 months ago Closed 12 days ago

Add startpage.com as search engine to all locales

Categories

(SeaMonkey :: Search, enhancement)

enhancement

Tracking

(seamonkey2.53? affected, seamonkey2.57esr? affected)

RESOLVED FIXED
seamonkey 2.80
Tracking Status
seamonkey2.53 ? affected
seamonkey2.57esr ? affected

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

Details

(Whiteboard: SM2.53.5)

Attachments

(1 file, 1 obsolete file)

Now that startpage.com have provided a new SM specific URL we should add as an option to all locales.

Attached patch Add startpage search (obsolete) — Splinter Review

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: No startpage.com search engine
Testing completed (on m-c, etc.): 2.53.4
Risk to taking this patch (and alternatives if risky): None
String changes made by this patch: None

Tested on en-US, en-GB and pl locales.
At the moment only version which is localised is the Polish one (not sure where the description shows).
Whilst I was there I thought I'd the search engines in alphabetical order, I don't think that it makes any difference but makes it easier to know where to put additional engines.

Attachment #9166091 - Flags: review?(frgrahl)
Attachment #9166091 - Flags: approval-comm-release?
Attachment #9166091 - Flags: approval-comm-esr60?
Comment on attachment 9166091 [details] [diff] [review]
Add startpage search

Let's start with feedback as I want to make sure it behaves as it should on non-English locales / operating systems. At the moment, it seems to pick up the language from the OS rather than the application.
Attachment #9166091 - Flags: review?(frgrahl)
Attachment #9166091 - Flags: feedback?(frgrahl)
Attachment #9166091 - Flags: approval-comm-release?
Attachment #9166091 - Flags: approval-comm-esr60?

Comment on attachment 9166091 [details] [diff] [review]
Add startpage search

As discussed over irc. The search works but is not location specific at the moment. startpage is investigating. f+ for the moment.

Attachment #9166091 - Flags: feedback?(frgrahl) → feedback+

Updated to include Startpage in the search order for some more locales

Attachment #9166091 - Attachment is obsolete: true
Attachment #9182187 - Flags: review?(frgrahl)
Attachment #9182187 - Flags: approval-comm-release?
Attachment #9182187 - Flags: approval-comm-esr60?

Comment on attachment 9182187 [details] [diff] [review]
Add startpage search v1.1

LGTM

Attachment #9182187 - Flags: review?(frgrahl)
Attachment #9182187 - Flags: review+
Attachment #9182187 - Flags: approval-comm-release?
Attachment #9182187 - Flags: approval-comm-release+
Attachment #9182187 - Flags: approval-comm-esr60?
Attachment #9182187 - Flags: approval-comm-esr60+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/c44151ad33d1
Add startpage.com as search engine to all locales. r=frg

Status: ASSIGNED → RESOLVED
Closed: 12 days ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey 2.80
You need to log in before you can comment on or make changes to this bug.