1655286 - Opening the Calendar tab grows the overall windows size. A full calendar is still not fully visible. No scrollbars. Can't shrink window height.

Status: VERIFIED FIXED

(Calendar :: General, defect, P1)

Description

[Jorg K (CEST = GMT+2)]

Opening the Calendar tab grows the overall windows size. A full calendar is still not fully visible. No scrollbars. Can't shrink window height.

Makes the thing pretty unusable.

Comment 1

[Jorg K (CEST = GMT+2)]

Attachment: before-after.png

Here a picture of TB before opening the Calendar tab and one after. This is in TB 78.1.

Alice, if you have time, can you find the regression?

Comment 2

[Alice0775 White]

Regression window:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=55f15b85ce9b7532b09d56840457304e79aa9406&tochange=d7b26f4d5ea17e94a0faee54f64783538bd6e0da
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=f20fa8068ec25d685914a5945f2c54e36c89bc65&tochange=a7ca5ad33f3df4477ddb16560386b1b5aa641c3b

Suspect:
[e-mail]
Thu Oct 10 22:05:05 2019 +0000 311c42a94e230fd1ba04e3d43e6cce2b12327fe9 Khushil Mistry — Bug 1582717 - remove grid usage from calendar-month-base-view.js. r=pmorris

Comment 3

[Jorg K (CEST = GMT+2)]

Thanks, Alice.

Comment 4

[Khushil Mistry [:khushil324]]

Is this windows specific issue?

Comment 5

[Jorg K (CEST = GMT+2)]

You need a full calendar. No issue with an empty one.

Comment 6

[Khushil Mistry [:khushil324]]

Attachment: Bug-1655286_calendar-resize-hegiht-issue-0.patch

Comment 7

[Jorg K (CEST = GMT+2)]

Comment on attachment 9166312 [details] [diff] [review]
Bug-1655286_calendar-resize-hegiht-issue-0.patch

I'm not a Calendar peer.

Comment 8

[Jorg K (CEST = GMT+2)]

Is this the right fix? Can you attach a screenshot? Instead of shrinking the height of the individual event, shouldn't there be a scrollbar? Or does the patch do that? I haven't tried.

Comment 9

[Geoff Lankow (:darktrojan)]

I've tried it, the patch works. I don't understand how it works, but the rows all stayed the same size and stopped growing my window every time I added an event.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/59daf305d6d1
Fix height issue on re-size in the calendar. r=pmorris

Comment 11

[Wayne Mery (:wsmwk)]

Comment on attachment 9166312 [details] [diff] [review]
Bug-1655286_calendar-resize-hegiht-issue-0.patch

Please remember to request uplift, especially on P1 issues.
Looks like low risk.
Approved for beta - I hope the calendar gods don't mind.

Comment 12

[Rob Lemley [:rjl]]

Thunderbird 80.0b1 (build4):
https://hg.mozilla.org/releases/comm-beta/rev/8f2aa937e14e

Comment 13

[Jorg K (CEST = GMT+2)]

Hi Wayne, thanks for tracking this down. At time of writing, I see three more bugs which should have been included in the current beta, all of them regressions and some P1 :-( - It is very regrettable that neither developer nor reviewer/module owner/peer set the uplift approval flags, but those bugs are findable via tracking, status or just by studying the previous release notes. I don't think the onus can be put on the bug reporter to see their own bugs through to uplift since the reporter may be "Joe Blow" who doesn't know the system.

Just out of curiosity, why did you not set the ESR flag here? As I said in comment #0, this bug makes the calendar unusable if you have many events and the windows is resized bigger than your physical screen with no chance to navigate to the off-screen events.

Comment 14

[Khushil Mistry [:khushil324]]

Comment on attachment 9166312 [details] [diff] [review]
Bug-1655286_calendar-resize-hegiht-issue-0.patch

[Approval Request Comment]
Regression caused by (bug #): 1582717
User impact if declined: Calendar will be problematic to use in a smaller screen.
Testing completed (on c-c, etc.): 
Risk to taking this patch (and alternatives if risky): Low.

Comment 15

[Jorg K (CEST = GMT+2)]

(In reply to Khushil Mistry [:khushil324] from comment #14)

User impact if declined: Calendar will be problematic to use in a smaller screen.

Actually, I have a 1680x1050 screen (big enough?) and Calendar is impossible to use, see attachment 9166092 [details], the rest of the month is cut off.

Comment 16

[Wayne Mery (:wsmwk)]

Comment on attachment 9166312 [details] [diff] [review]
Bug-1655286_calendar-resize-hegiht-issue-0.patch

[Triage Comment]
Approved for esr78

Comment 17

[Rob Lemley [:rjl]]

Thunderbird 78.1.1:
https://hg.mozilla.org/releases/comm-esr78/rev/e2a1147bb751

Comment 18

[Jorg K (CEST = GMT+2)]

Works in TB 78.1.1 ESR.