1655324 - Rewrite DOMSVGAnimatedString

Status: RESOLVED FIXED

(Core :: SVG, task)

Comment 1

[Robert Longson [:longsonr]]

Attachment: Bug 1655324 - rewrite DOMSVGAnimatedString

• Convert DOMSVGAnimatedString to a concrete class rather than having two almost indentical derived classes that differ only by the class of the mVal pointer
• Introduce tear off support for SVGAnimatedClass
• Move to native refcounting rather than nsISupports

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8829157669b1
rewrite DOMSVGAnimatedString r=heycam

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

Backed out changeset 8829157669b1 (bug 1655324) for SVGAnimatedClassOrString.h related bustage

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&fromchange=8829157669b14f63633d1f9ee2c29ac007453f54&searchStr=build&tochange=ade623dc21d623533bd619b4cf7bc1cbc8196ad9&selectedTaskRun=f85b2z4kSFWvwVMIFZmLTA.0

Backout link: https://hg.mozilla.org/integration/autoland/rev/ade623dc21d623533bd619b4cf7bc1cbc8196ad9

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=312550660&repo=autoland&lineNumber=13159

[task 2020-08-10T04:18:05.890Z] 04:18:05     INFO -  make[4]: Entering directory '/builds/worker/workspace/obj-build/dom/bindings'
[task 2020-08-10T04:18:05.890Z] 04:18:05     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang++ -std=gnu++17 --target=x86_64-linux-android -o UnifiedBindings18.o -c  -I/builds/worker/workspace/obj-build/dist/stl_wrappers -I/builds/worker/workspace/obj-build/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -fstack-protector-strong -ftrivial-auto-var-init=pattern -DDEBUG=1 -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DOS_POSIX=1 -DOS_LINUX=1 -DHAVE_SIDEBAR -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/dom/bindings -I/builds/worker/workspace/obj-build/dom/bindings -I/builds/worker/workspace/obj-build/dist/include/mozilla/dom -I/builds/worker/checkouts/gecko/dom/base -I/builds/worker/checkouts/gecko/dom/battery -I/builds/worker/checkouts/gecko/dom/canvas -I/builds/worker/checkouts/gecko/dom/geolocation -I/builds/worker/checkouts/gecko/dom/html -I/builds/worker/checkouts/gecko/dom/indexedDB -I/builds/worker/checkouts/gecko/dom/media/webaudio -I/builds/worker/checkouts/gecko/dom/media/webspeech/recognition -I/builds/worker/checkouts/gecko/dom/svg -I/builds/worker/checkouts/gecko/dom/xml -I/builds/worker/checkouts/gecko/dom/xslt/base -I/builds/worker/checkouts/gecko/dom/xslt/xpath -I/builds/worker/checkouts/gecko/dom/xul -I/builds/worker/checkouts/gecko/js/xpconnect/src -I/builds/worker/checkouts/gecko/js/xpconnect/wrappers -I/builds/worker/checkouts/gecko/layout/generic -I/builds/worker/checkouts/gecko/layout/style -I/builds/worker/checkouts/gecko/layout/xul/tree -I/builds/worker/checkouts/gecko/media/mtransport -I/builds/worker/checkouts/gecko/media/webrtc -I/builds/worker/checkouts/gecko/media/webrtc/signaling/src/common/time_profiling -I/builds/worker/checkouts/gecko/media/webrtc/signaling/src/peerconnection -I/builds/worker/checkouts/gecko/media/webrtc/trunk -I/builds/worker/checkouts/gecko/media/webrtc/trunk/webrtc -I/builds/worker/checkouts/gecko/netwerk/base -I/builds/worker/checkouts/gecko/third_party/msgpack/include -I/builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders -I/builds/worker/checkouts/gecko/ipc/chromium/src -I/builds/worker/checkouts/gecko/ipc/glue -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/mozilla-config.h -Qunused-arguments -isystem /builds/worker/fetches/android-ndk/sysroot/usr/include/x86_64-linux-android -isystem /builds/worker/fetches/android-ndk/sysroot/usr/include -gcc-toolchain /builds/worker/fetches/android-ndk/toolchains/x86_64-4.9/prebuilt/linux-x86_64 -D__ANDROID_API__=21 -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Wunused-function -Wunused-variable -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-error=tautological-type-limit-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=return-std-move -Wno-error=atomic-alignment -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Werror=implicit-function-declaration -Wno-unknown-warning-option -fno-sized-deallocation -fno-aligned-new -fno-short-enums -fno-exceptions -stdlib=libstdc++ -I/builds/worker/fetches/android-ndk/sources/cxx-stl/llvm-libc++/include -I/builds/worker/fetches/android-ndk/sources/android/support/include -I/builds/worker/fetches/android-ndk/sources/cxx-stl/llvm-libc++abi/include -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pipe -g -Xclang -load -Xclang /builds/worker/workspace/obj-build/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -fno-omit-frame-pointer -funwind-tables -Werror -Wno-error=shadow -Wno-maybe-uninitialized -fexperimental-new-pass-manager  -MD -MP -MF .deps/UnifiedBindings18.o.pp   UnifiedBindings18.cpp
[task 2020-08-10T04:18:05.890Z] 04:18:05     INFO -  In file included from UnifiedBindings18.cpp:2:
[task 2020-08-10T04:18:05.890Z] 04:18:05     INFO -  In file included from /builds/worker/workspace/obj-build/dom/bindings/SVGFEMergeNodeElementBinding.cpp:4:
[task 2020-08-10T04:18:05.890Z] 04:18:05     INFO -  In file included from /builds/worker/checkouts/gecko/dom/svg/DOMSVGAnimatedString.h:10:
[task 2020-08-10T04:18:05.890Z] 04:18:05    ERROR -  /builds/worker/workspace/obj-build/dist/include/mozilla/SVGAnimatedClassOrString.h:31:3: error: no template named 'already_AddRefed'
[task 2020-08-10T04:18:05.890Z] 04:18:05     INFO -    already_AddRefed<dom::DOMSVGAnimatedString> ToDOMAnimatedString(
[task 2020-08-10T04:18:05.890Z] 04:18:05     INFO -    ^
[task 2020-08-10T04:18:05.890Z] 04:18:05     INFO -  1 error generated.
[task 2020-08-10T04:18:05.890Z] 04:18:05    ERROR -  make[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:720: UnifiedBindings18.o] Error 1
[task 2020-08-10T04:18:05.890Z] 04:18:05     INFO -  make[4]: Leaving directory '/builds/worker/workspace/obj-build/dom/bindings'
[task 2020-08-10T04:18:05.890Z] 04:18:05     INFO -  make[4]: *** Waiting for unfinished jobs....

Comment 4

[Robert Longson [:longsonr]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0b24aee91402c6ca5a5995613e781f4f51a38fda

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b7e99a7ddba2
rewrite DOMSVGAnimatedString r=heycam

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/b7e99a7ddba2