1655385 - Telemetry ping contains null values

Status: RESOLVED FIXED

(Conduit :: moz-phab, defect, P2)

Description

[Piotr Zalewa [:zalun]]

Some of the pings are sent with null value.

This query has found 4 pings within the last 24h.

SELECT 
    CAST(metrics.timespan.mozphab_usage_command_time.value/1000 AS INT64) AS seconds,
    metrics.counter.mozphab_submission_commits_count AS commits

FROM mozphab.usage 
WHERE
    DATE(submission_timestamp) >= DATE_SUB(CURRENT_DATE(), INTERVAL 1 DAY)
    AND metrics.counter.mozphab_submission_commits_count IS null

Comment 1

[Piotr Zalewa [:zalun]]

This happens when the user chooses to not continue in here: https://github.com/mozilla-conduit/review/blob/master/mozphab/commands/submit.py#L421

We have two options:

1. Raise an `Error("Cancelled.")
2. Add a new metric and measure how often user hasn't continued.

I lean to the latter. More data is good for us.

IMPORTANT
All performance queries should:

1. check for this measure as the command_time can grow significantly.
2. display preparation_time + process_time instead of command_time as it contains user reaction to the prompt.

Comment 2

[Alessio Placitelli [:Dexter]]

(In reply to Piotr Zalewa [:zalun] from comment #1)

IMPORTANT
All performance queries should:

1. check for this measure as the command_time can grow significantly.
2. display preparation_time + process_time instead of command_time as it contains user reaction to the prompt.

It would make sense to add the above details on the related metric 'description' in the metrics.yaml file.

Comment 3

[Piotr Zalewa [:zalun]]

Attachment: Bug 1655385 - Measure rejected submit stack size. r=zeid

Comment 4

[:glob ✱]

https://github.com/mozilla-conduit/review/commit/264da0aad42b9a2aa259a20773ef42cb7036d097