Closed Bug 1655430 Opened 4 years ago Closed 4 years ago

De-duplicate MakeAnonymousElement from nsSearchControlFrame and nsNumberControlFrame

Categories

(Core :: Layout: Form Controls, task)

task

Tracking

()

RESOLVED FIXED
81 Branch
Tracking Status
firefox81 --- fixed

People

(Reporter: ntim, Assigned: emilio)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Emilio mentioned it should probably be renamed to CreateEmptyAnonymousDivWithPseudo and made a protected function in nsTextControlFrame.

Component: Layout → Layout: Form Controls
Flags: needinfo?(emilio)
Flags: needinfo?(emilio)
Assignee: nobody → emilio
Status: NEW → ASSIGNED
Attachment #9166252 - Attachment description: Bug 1655430 - Deduplicate a bit code to create anonymous elements in ns{Number,SearchText}ControlFrame. r=#layout-reviewers → Bug 1655430 - Deduplicate a bit code to create anonymous elements in ns{Number,Search,Text}ControlFrame. r=#layout-reviewers
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/21877917f903
Remove some useless namespacing in nsTextControlFrame.h. r=jfkthame
https://hg.mozilla.org/integration/autoland/rev/7e18e98a4700
Deduplicate a bit code to create anonymous elements in ns{Number,Search,Text}ControlFrame. r=jfkthame
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: