1655442 - Make usage of nsIWorkerDebugger.addListener more explicit

Status: RESOLVED FIXED

(DevTools :: Framework, task)

Description

[Nicolas Chevobbe [:nchevobbe]]

In a few places were calling addListener on worker debugger with this. Often, the class we're using this in has multiple method, and it's hard to know what's needed for the listener and what's not.

The listener takes only 3 possible method (https://searchfox.org/mozilla-central/source/__GENERATED__/dist/include/nsIWorkerDebugger.h#31-45):

• onClose
• onError
• onMessage

We should explicitly specify those listeners instead of using this, so one does not have to dig through internals to find out what these addListener are doing.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1655442 - Make usage of nsIWorkerDebugger.addListener more explicit. r=loganfsmyth

Declare separate listener objects instead of relying on the presence of the
listener method in a broader class.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d96dc5d7910a
Make usage of nsIWorkerDebugger.addListener more explicit. r=loganfsmyth

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/d96dc5d7910a