1655485 - Exit search mode if prefs were flipped

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

I was testing our current implementation, I flipped the prefs on, then I enabled search mode in a tab clicking a one-off, then I flipped the prefs off.
At this point I was trapped in search mode.

Comment 1

[Harry Twyford]

Attachment: Bug 1655485 - Exit search mode if update2 pref is flipped. r?adw!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6faa35a6346f
Exit search mode if update2 pref is flipped. r=adw

Comment 3

[Atila Butkovits]

Backed out for failure at browser_searchModeIndicator.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/7f23332eee3f4449ae0c7fc3d7161d398f2ea06f

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=6faa35a6346f3cf6c3ba112593896b68d23b7b4e&searchStr=bc&selectedTaskRun=fk6gUIDTQV-VXtm-bXU6vA.0

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=312187850&repo=autoland&lineNumber=12221

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6fb142c3cd82
Exit search mode if update2 pref is flipped. r=adw

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/6fb142c3cd82

Comment 6

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

I verified this issue using 82.0a1 (2020-09-14) on macOS 10.13 and Windows 10 x64.
Adrian could you help me with Ubuntu verification?

Comment 7

[Petruta Horea [:phorea], Desktop QA]

Verified as fixed using Firefox 81RC and latest Nightly 82.0a1 2020-09-17 under Ubuntu 18 64-bit.