1655581 - [css-grid] Growth limits not increased with min-content contributions of spanning items

Status: RESOLVED FIXED

(Core :: Layout: Grid, defect)

Description

[Mozilla Apprentice]

A resolution was made for csswg-drafts/#4790.

[css-grid] Growth limits not increased with min-content contributions of spanning items

• RESOLVED: Accept the edits made to the ED re minimum vs min-content (and add WPT tests)

Discussion.

Comment 1

[Oriol Brufau [:Oriol]]

Basically, revert https://bugzilla.mozilla.org/show_bug.cgi?id=1255393#c12

https://searchfox.org/mozilla-central/rev/56bb74ea8e04bdac57c33cbe9b54d889b9262ade/layout/generic/nsGridContainerFrame.cpp#2113-2122 should become

      switch (phase) {
        case TrackSizingPhase::IntrinsicMinimums:
          return mMinSize;
        case TrackSizingPhase::ContentBasedMinimums:
        case TrackSizingPhase::IntrinsicMaximums:
          return mMinContentContribution;
        case TrackSizingPhase::MaxContentMinimums:
        case TrackSizingPhase::MaxContentMaximums:
          return mMaxContentContribution;
      }

Comment 2

[Oriol Brufau [:Oriol]]

Attachment: Bug 1655581 - [css-grid] Use min-content size for intrinsic maximums resolution. r?mats

By mistake the specification used to say that, for items spanning
multiple tracks, the growth limits of the tracks with an intrinsic max
track sizing function should grow to accommodate the minimum
contribution of the item.

But this was a mistake, because an intrinsic max track sizing function
can only be min-content or max-content. So instead of distributing the
minimum contribution, it should be the min-content contribution.

The spec has been fixed and there is a CSSWG resolution in
https://github.com/w3c/csswg-drafts/issues/4790

This patch fixes the problem by reverting 2b923d48ea7e. The change is
likely web compatible, since it only affects a rare edge case with
'minmax()' where the min sizing function is 'auto' or a fixed value
smaller than the min-content contribution, the max sizing function is
'min-content', and an item whose minimum contribution is forced to be
smaller than the min-content contribution, and spans multiple tracks.

Comment 3

[Oriol Brufau [:Oriol]]

Fixed in Chromium: https://bugs.chromium.org/p/chromium/issues/detail?id=1122084
And WebKit: https://bugs.webkit.org/show_bug.cgi?id=216142

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c8322fb7a54a
[css-grid] Use min-content size for intrinsic maximums resolution. r=mats

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/c8322fb7a54a