1655636 - avoid reinitializing the timers in HTTP3

Status: RESOLVED FIXED

(Core :: Networking: HTTP, enhancement, P2)

Comment 1

[Dragana Damjanovic [:dragana]]

Will this be fixed by bug 1646024?

Comment 2

[Junior [inactive]]

Thanks for referring to this.
I've been patched bug 1646024 and I still saw several SetupTimer from Read or Write before the previous one is fired.

Comment 3

[Junior [inactive]]

I had a patch and will post it later. It will ease the implementation of the timer probe in bug 1655566

Comment 4

[Junior [inactive]]

We might overwrite the timer accenditally. Raise the severity.

Comment 5

[Junior [inactive]]

Attachment: Bug 1655636 - avoid reinitializing the timers for ProcessOutputAndEvents, r=dragana

SetupTimer came from [Read|Write]SegmentsAgain and could be set before the previous one fire.
Therefore, it will accenditally remove the previous one and set the new timeout by current timer implementation.

If we set a long timeout, the previous timer could be wrongly removed.

Comment 6

[BugBot [:suhaib / :marco]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:CuveeHsu, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/40bdd210fd2f
avoid reinitializing the timers for ProcessOutputAndEvents, r=dragana,necko-reviewers

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/40bdd210fd2f

Comment 9

[Junior [inactive]]

Thanks, Dragana.