1655649 - Adds the possibility to edit log and condition in the same UI

Status: NEW

(DevTools :: Debugger, enhancement, P3)

Description

[Karl Dubost💡 :karlcow]

Attachment: log-devtools-w-cond.jpg

This is not a bug,
The current UI for adding log to the debugger could probably be improved. I didn't realize that we could add a condition to the logging with the current UI.

It could be useful to be able to see both fields at the same if cond is left empty then the log has no conditions.

Comment 1

[Karl Dubost💡 :karlcow]

Other issues

1. The current UI is 'Add log' and 'Add condition' can't be seen together at the same time.
2. if the log UI is open and we type command+shit+B to add a condition, it closes the log UI, but doesn't open the condition UI
3. We know when there is a log set, but if there is an additional condition set, it's not visible except if we re-edit the condition.

Comment 2

[Victoria Wang [:victoria]]

Thanks for filing this, Karl! Your mockup looks great :D.

CC Harald

Comment 3

[:Harald Kirschner :digitarald]

I agree, having both would be great, reduce the overloaded Add x menu items and avoid the blur-based editing quirks.

Throwing in my logpoint mockups from Sep 2019: https://www.figma.com/file/j42gN7Kjko8NcJfb6aVDIQ/Logpoints?node-id=0%3A1

Comment 4

[Karl Dubost💡 :karlcow]

fancier tools than my pen ;)
I like the first layout exhibit A

Also probably not part of MVP but could be useful.
currently in the UI the the line has an orange flag to make it different from a breakpoint.
Could we get the same flag color at the beginning of the line in the console. So there is a distinction between the logs of the app or firefox.
This can help when there is an app which is quite chatty already.