1655779 - Crash in [@ mozilla::a11y::GeckoTextMarkerRange::LinkCount]

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect, P1)

Description

[Marco Zehe (:MarcoZ)]

This bug is for crash report bp-b6f60a04-8bbf-46c0-b287-fc98c0200728.

Top 10 frames of crashing thread:

0 XUL mozilla::a11y::GeckoTextMarkerRange::LinkCount const accessible/mac/GeckoTextMarker.mm:301
1 XUL mozilla::a11y::GeckoTextMarkerRange::TextInternal const accessible/mac/GeckoTextMarker.mm:329
2 XUL mozilla::a11y::GeckoTextMarkerRange::Text const accessible/mac/GeckoTextMarker.mm:262
3 XUL -[MOXTextMarkerDelegate moxStringForTextMarkerRange:] accessible/mac/MOXTextMarkerDelegate.mm:110
4 XUL -[MOXTextMarkerDelegate moxLengthForTextMarkerRange:] accessible/mac/MOXTextMarkerDelegate.mm:114
5 XUL -[MOXAccessibleBase accessibilityAttributeValue:forParameter:] accessible/mac/MOXAccessibleBase.mm:292
6 AppKit AppKit@0x679c3d 
7 AppKit AppKit@0x6753c9 
8 AppKit AppKit@0x676737 
9 AppKit AppKit@0x479460 

I was doing the following:

1. From the "You've just been upgraded to Nightly 81", chose the SignIn button.
2. Was brought to the Firefox Accounts sign in page. User name and password were already filled out from credentials saved in about:logins.
3. Hit the Sign In button, or just pressed Enter on the password field to submit the form.
4. I have 2FA set up on my account, so Firefox comes back asking me for a 2-factor code from an authenticator app. This is when it crashes. I briefly hear that the focus is in the field for the code, then I am dropped first back to Finder, then to Moz Crash Reporter.

This is reproducible 100% of the time. Another report of this is here.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1655779 - Check that range is valid before getting its string. r?MarcoZ

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/186633314968
Check that range is valid before getting its string. r=MarcoZ

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/186633314968

Comment 4

[Eitan Isaacson [:eeejay]]

Comment on attachment 9166597 [details]
Bug 1655779 - Check that range is valid before getting its string. r?MarcoZ

Beta/Release Uplift Approval Request

• User impact if declined: Potential crash
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is just a check to see if an input argument is valid.
• String changes made/needed:

Comment 5

[Julien Cristau [:jcristau]]

Comment on attachment 9166597 [details]
Bug 1655779 - Check that range is valid before getting its string. r?MarcoZ

mac a11y crash fix, approved for 80.0b4

Comment 6

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/cc7f77b96f95