Closed
Bug 1655813
Opened 4 years ago
Closed 4 years ago
[mozdevice] better handle executing command lines containing both single and double quotes
Categories
(Testing :: Mozbase, defect)
Tracking
(firefox81 fixed)
RESOLVED
FIXED
81 Branch
| Tracking | Status | |
|---|---|---|
| firefox81 | --- | fixed |
People
(Reporter: bc, Assigned: bc)
References
Details
Attachments
(1 file)
bug 1653301 illustrates a problem when executing command lines containing both single and double quotes especially when constructing the command line when executing under su.
I think the long term solution here is to use shlex but the required features (join) are not available in Python 2 nor older versions of Python 3.
|
Assignee | |
Comment 1•4 years ago
|
||
As a ride-along, I've included a fix to convert the verbose logging output of the adb process stdout during
the ADBDevice.shell method.
Pushed by bclary@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a4d6560a6e57 [mozdevice 4.0.2] better handle executing shell command lines containing both single and double quotes. r=jmaher
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox81:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
|
|
Assignee | |
Comment 4•4 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•