1655838 - Error "no localization found for [undefined]" when a blocked request is displayed in the console

Status: RESOLVED FIXED

(DevTools :: Console, defect, P3)

Description

[Julian Descottes [:jdescottes]]

STRs:

• block any request in the netmonitor
• show requests in the console
• trigger the blocked request

An error will be logged : no localization found for [undefined]

For blocked requests, we create a MessageIcon component with no "level", but level is a mandatory property and is used to call l10n's getStr:

Component created at:
https://searchfox.org/mozilla-central/rev/d9f92154813fbd4a528453c33886dc3a74f27abb/devtools/client/webconsole/components/Output/Message.js#183

L10n called at:
https://searchfox.org/mozilla-central/rev/d9f92154813fbd4a528453c33886dc3a74f27abb/devtools/client/webconsole/components/Output/MessageIcon.js#30

Error is logged at:
https://searchfox.org/mozilla-central/rev/d9f92154813fbd4a528453c33886dc3a74f27abb/devtools/shared/l10n.js#130

The error is simply logged. Might be nice to still provide a level, since it's mandatory, but this shouldn't impact the behavior of the console.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1655838 - Set ERROR level for blocked request messages in Webconsole

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/176ff21be520
Set ERROR level for blocked request messages in Webconsole r=nchevobbe

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/176ff21be520