1655924 - Race condition happening when creating or resizing widgets

Status: NEW

(Core :: Widget: Gtk, defect, P3)

Description

[Nicolas Silva [:nical]]

gdk_window_get_origin blocks on a synchronous x server query, which causes performance issues. However, removing the sycnrhonous query causes regressions such as bug 1652743 and bug 1653711, which look related to some kind of race condition during resize or around the creation of a window, and that race condition appears to be hidden by the frequent synchronous queries. The regression doesn't depend on the way the window origin is computed but only on whether a synchronous query happens before computing the window origin.

Comment 1

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1655924 - Part 2: Consistently update supported interfaces in nsViewSourceChannel,

Previously, the updates in OnStartRequest were not updating some of the
interface fields, including nsIHttpChannelInternal, which caused the wrong
channel object to be queried for Cross-Origin-Opener-Policy status during
process switches after a redirect, and crashes.

In the browser_application_panel_viewsource-service-worker.js test case, the
http channel was being intercepted by a service worker, but the non-intercepted
channel was being queried. As the non-intercepted channel had not observed
OnStartRequest, the query failed.

Comment 2

[Phabricator Automation]

Comment on attachment 9191060 [details]
Bug 1655924 - Part 2: Consistently update supported interfaces in nsViewSourceChannel,

Revision D98619 was moved to bug 1670530. Setting attachment 9191060 [details] to obsolete.