1655928 - Add SpiderMonkey-side artefacts to support Wasm Atomics on Cranelift/newBE/AArch64 (CL PR2077)

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, enhancement, P1)

Description

[Julian Seward [:jseward]]

Cranelift PR2077 adds support for Wasm Atomics via the newBE/AArch64 pipeline. This requires a few changes on the SM side:

• a change to compiler gating logic

• translation of WaitI32/WaitI64/Notify requests into the relevant SM-side instance calls

Comment 1

[Julian Seward [:jseward]]

Attachment: atomics-SM.diff-15

Comment 2

[Julian Seward [:jseward]]

Attachment: atomics-SM.diff-16

Comment 3

[Julian Seward [:jseward]]

Here's a link to the corresponding CL-side PR, for everybody's clicking convenience:
https://github.com/bytecodealliance/wasmtime/pull/2077

Comment 4

[Julian Seward [:jseward]]

Attachment: Bug 1655928 - Add SpiderMonkey-side artefacts to support Wasm Atomics on Cranelift/newBE/AArch64 (CL PR2077).

Cranelift PR2077 adds support for Wasm Atomics via the newBE/AArch64
pipeline. This requires a few changes on the SM side:

• a change to compiler gating logic, allowing CL on AArch64 to support threads/atomics

• translation of WaitI32/WaitI64/Notify requests into the relevant SM-side
  instance calls

  • three more BD_SymbolicAddress:: values
  • a binding for CL's HeapMisaligned trap code, which is new
  • in wasm2clif.rs, a new error-reporting mode: IsNegative32, and handling thereof
  • in wasm2clif.rs, translation of wait_i32/wait_i64/notify to instance calls

Comment 5

[Julian Seward [:jseward]]

Attachment: Bug 1655928 - Add SpiderMonkey-side artefacts to support Wasm Atomics on Cranelift/newBE/AArch64 (CL PR2077). r=cfallin.

Cranelift PR2077 adds support for Wasm Atomics via the newBE/AArch64
pipeline. This requires a few changes on the SM side:

• a change to compiler gating logic, allowing CL on AArch64 to support threads/atomics

• translation of WaitI32/WaitI64/Notify requests into the relevant SM-side
  instance calls

  • three more BD_SymbolicAddress:: values
  • a binding for CL's HeapMisaligned trap code, which is new
  • in wasm2clif.rs, a new error-reporting mode: IsNegative32, and handling thereof
  • in wasm2clif.rs, translation of wait_i32/wait_i64/notify to instance calls

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/057cd099f3bc
Add SpiderMonkey-side artefacts to support Wasm Atomics on Cranelift/newBE/AArch64 (CL PR2077).  r=cfallin.

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/057cd099f3bc