1655933 - Can't print uncacheable images.

Status: VERIFIED FIXED

(Core :: Printing: Output, defect, P3)

Description

[Emilio Cobos Álvarez (:emilio)]

STR:

• Go to https://picsum.photos
• Print

ER:

• The photo you're seeing in the document is printed.

AR:

• We reload the image and get a different one (potentially).

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1655933 - Allow images from non-static documents to get reused in their static clones without validation. r=tnikkel

This allows to print images that we'd otherwise reload.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1648064

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1cdb7ea0225d
Allow images from non-static documents to get reused in their static clones without validation. r=tnikkel

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/1cdb7ea0225d

Comment 5

[Julien Cristau [:jcristau]]

Should we uplift this one as well?

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9166790 [details]
Bug 1655933 - Allow images from non-static documents to get reused in their static clones without validation. r=tnikkel

Beta/Release Uplift Approval Request

• User impact if declined: Can't print uncacheable images.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple change to the image cache to allow reuse of non-cacheable images for printing
• String changes made/needed: none

Comment 7

[Julien Cristau [:jcristau]]

Comment on attachment 9166790 [details]
Bug 1655933 - Allow images from non-static documents to get reused in their static clones without validation. r=tnikkel

printing regression, approved for 80.0b3

Comment 8

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/96d049456d4c

Comment 9

[Emil Ghitta, QA [:emilghitta]]

Reproduced this issue using Firefox 81.0a1 (BuildId:20200728213249).

This issue is verified fixed using Firefox 81.0a1 (BuildId:20200802214843) and Firefox 80.0b3 (BuildId:20200803045446) on Windows 10 64bit, macOS 10.14 and Ubuntu 18.04 64bit.