Closed Bug 1655946 Opened 2 months ago Closed 2 months ago

Add X-Target-URL header to top site attribution requests

Categories

(Firefox :: Top Sites, task, P1)

task
Points:
2

Tracking

()

RESOLVED FIXED
81 Branch
Iteration:
81.1 - July 27 - Aug 09
Tracking Status
firefox80 --- fixed
firefox81 --- fixed

People

(Reporter: dao, Assigned: dao)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f77bb89f9def
Add X-Target-URL header to top site attribution requests. r=mikedeboer

Comment on attachment 9166802 [details]
Bug 1655946 - Add X-Target-URL header to top site attribution requests. r=mikedeboer

Beta/Release Uplift Approval Request

  • User impact if declined: Mike de Boer says he would like to have this in Firefox 80 so the server component can already use it.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Code is disabled by default until we choose to enable it.
  • String changes made/needed:
Attachment #9166802 - Flags: approval-mozilla-beta?
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch

What does this do?

Flags: needinfo?(dao+bmo)

(In reply to Julien Cristau [:jcristau] from comment #5)

What does this do?

We're in the process of moving our default top sites (that are shown on the new tab page and when clicking in the address bar in new profiles) to remote settings. Those are potentially monetized, and to that end we need to make an attribution request to a Mozilla server. This patch adds the URL of the default top site to that request. This work is primarily for Firefox 81, but we're fast-tracking based on experiment code: https://docs.google.com/document/d/100u8W0eWGuqjzxuK3UhXIK6Lnt0fqftcNPWfOxOUV5Y/edit?ts=5f2076eb

Flags: needinfo?(dao+bmo)

This sounds like new/expanded data collection, should it be looked at by a data steward?

Flags: needinfo?(dao+bmo)

(In reply to Julien Cristau [:jcristau] from comment #7)

This sounds like new/expanded data collection, should it be looked at by a data steward?

No, we're not collecting this data. On top of that, we're sending along the URL that we set in a pref, so it's not user-data, but ours. We're sending this along with the request to do a sanity check on the server side.

In the future we'll be using this mechanism for search queries to specific partners, but in that case we'll be stripping out all information that we're not the source of (i.e. it's the user's, like a search query).

Thanks for flagging!

Flags: needinfo?(dao+bmo)

Comment on attachment 9166802 [details]
Bug 1655946 - Add X-Target-URL header to top site attribution requests. r=mikedeboer

approved for 80.0b4

Attachment #9166802 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.