1655993 - Remove Punion_Comparable::test from sync-messages.ini

Status: RESOLVED FIXED

(Core :: IPC, defect)

Comment 1

[Ricky Stewart]

Attachment: Bug 1655993 - Remove Punion_Comparable::test from sync-messages.ini

This shouldn't have been added in the first place.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8de8073d7fab
Remove Punion_Comparable::test from sync-messages.ini r=mccr8

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/8de8073d7fab

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1654589

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:rstewart, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 6

[Ricky Stewart]

Comment on attachment 9166841 [details]
Bug 1655993 - Remove Punion_Comparable::test from sync-messages.ini

Beta/Release Uplift Approval Request

• User impact if declined: Certain build recipes (e.g. make check) can display failures unnecessarily.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This fixes a unit test.
• String changes made/needed:

Comment 7

[Julien Cristau [:jcristau]]

Comment on attachment 9166841 [details]
Bug 1655993 - Remove Punion_Comparable::test from sync-messages.ini

test-only change

Comment 8

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/b1b6a35710db

Comment 9

[Julien Cristau [:jcristau]]

This appears to have broken the valgrind-linux64-valgrind/opt job on beta:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-beta&revision=94796901f6c29c965a1ecbbc2a9764826f620154&selectedTaskRun=DAFeWdfYTCqwIG71SSGqiQ.0

Seems we need bug 1655371 there also?

Comment 10

[Ricky Stewart]

Makes sense to me.