Closed Bug 1655993 Opened 2 months ago Closed 2 months ago

Remove Punion_Comparable::test from sync-messages.ini

Categories

(Core :: IPC, defect)

defect

Tracking

()

RESOLVED FIXED
81 Branch
Tracking Status
firefox-esr68 --- unaffected
firefox-esr78 --- unaffected
firefox79 --- unaffected
firefox80 --- fixed
firefox81 --- fixed

People

(Reporter: rstewart, Assigned: rstewart)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

No description provided.

This shouldn't have been added in the first place.

Component: General → IPC
Product: Firefox Build System → Core
Assignee: nobody → rstewart
Status: NEW → ASSIGNED
Pushed by rstewart@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8de8073d7fab
Remove Punion_Comparable::test from sync-messages.ini r=mccr8
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch

The patch landed in nightly and beta is affected.
:rstewart, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(rstewart)

Comment on attachment 9166841 [details]
Bug 1655993 - Remove Punion_Comparable::test from sync-messages.ini

Beta/Release Uplift Approval Request

  • User impact if declined: Certain build recipes (e.g. make check) can display failures unnecessarily.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This fixes a unit test.
  • String changes made/needed:
Flags: needinfo?(rstewart)
Attachment #9166841 - Flags: approval-mozilla-beta?

Comment on attachment 9166841 [details]
Bug 1655993 - Remove Punion_Comparable::test from sync-messages.ini

test-only change

Attachment #9166841 - Flags: approval-mozilla-beta?
Whiteboard: [checkin-needed-beta]
Flags: needinfo?(rstewart)

Makes sense to me.

Flags: needinfo?(rstewart)
You need to log in before you can comment on or make changes to this bug.