Closed Bug 1656065 Opened 4 months ago Closed 4 months ago

SUMMARY: ThreadSanitizer: data race /builds/worker/checkouts/gecko/media/mtransport/third_party/nrappkit/src/log/r_log.c:349:8 in r_vlog

Categories

(Core :: WebRTC: Networking, defect, P5)

defect

Tracking

()

RESOLVED FIXED
81 Branch
Tracking Status
firefox81 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: bwc)

References

Details

Attachments

(1 file)

Looks like we're racing on this:

https://searchfox.org/mozilla-central/rev/cffd9b5302b6b6f51533d895a785b48ff418aec1/media/mtransport/third_party/nrappkit/src/log/r_log.c#349

Looks pretty much benign, but we may be racing against other parts of r_log_init.

So it looks like we run this code in _r_log_init over and over again:

https://searchfox.org/mozilla-central/rev/cffd9b5302b6b6f51533d895a785b48ff418aec1/media/mtransport/third_party/nrappkit/src/log/r_log.c#655-661

We should probably be doing this only once, right?

Flags: needinfo?(ekr)

Yeah.

r_log_init() is only supposed to be called once, I think. Or we should add an "i have already been called" thing.

Flags: needinfo?(ekr)

Depends on D85295

Assignee: nobody → docfaraday
Status: NEW → ASSIGNED

Try looks good.

Pushed by bcampen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f39ddb6e8d4c
Init r_log_env_verbose only once. r=mjf
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
You need to log in before you can comment on or make changes to this bug.