1656065 - SUMMARY: ThreadSanitizer: data race /builds/worker/checkouts/gecko/media/mtransport/third_party/nrappkit/src/log/r_log.c:349:8 in r_vlog

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: bcampen [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=311427428&repo=try
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/ML1-bUG7S_uyOMyYy3NqEw/runs/0/artifacts/public/logs/live_backing.log

---

Comment 1

[Byron Campen [:bwc]]

Looks like we're racing on this:

https://searchfox.org/mozilla-central/rev/cffd9b5302b6b6f51533d895a785b48ff418aec1/media/mtransport/third_party/nrappkit/src/log/r_log.c#349

Looks pretty much benign, but we may be racing against other parts of r_log_init.

Comment 2

[Byron Campen [:bwc]]

So it looks like we run this code in _r_log_init over and over again:

https://searchfox.org/mozilla-central/rev/cffd9b5302b6b6f51533d895a785b48ff418aec1/media/mtransport/third_party/nrappkit/src/log/r_log.c#655-661

We should probably be doing this only once, right?

Comment 3

[Eric Rescorla (:ekr)]

Yeah.

r_log_init() is only supposed to be called once, I think. Or we should add an "i have already been called" thing.

Comment 4

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f1725eb54eebdcbf3f117cefe07b7254ebe38657

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4a36db7576f34b614c78a97b271eb28d6022bf4b

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9ea00297c4af9b8d1e4b38f876124219229d258f

Comment 5

[Byron Campen [:bwc]]

Attachment: Bug 1656065: Init r_log_env_verbose only once. r?mjf

Depends on D85295

Comment 6

[Byron Campen [:bwc]]

Try looks good.

Comment 7

[Intermittent Failures Robot]

1 failures in 4289 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 1

Platform breakdown:

• linux1804-64-tsan: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1656065&startday=2020-07-27&endday=2020-08-02&tree=all

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f39ddb6e8d4c
Init r_log_env_verbose only once. r=mjf

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/f39ddb6e8d4c