1656071 - Add a way to dump profiler stats into a capture

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, task)

Description

[Kartikaya Gupta (email:[e-mail])]

I had cooked up a patch (semi-cleaned up version here) to dump WR's internal profiler sample data to a file in the WR capture. This was useful in breaking down a talos regression that I couldn't reproduce locally, since bug 1654373 allows us to get captures from WR when running in talos. The patch can be cleaned up further and landed as it might be useful to others.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

The yak-shaving expedition begins...

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1656071 - Record profiler stats into captures to assist with debugging talos regressions. r?kvark

This adds a profiler-stats.txt file to captures that dumps the profiler
stats, if those are being recorded. They get recorded if the profiler is
visible, or if the (newly added) PROFILER_CAPTURE debug option is enabled.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0d50962a0bb9
Record profiler stats into captures to assist with debugging talos regressions. r=kvark

Comment 4

[Atila Butkovits]

Backed out for wrench failures.

Backout link: https://hg.mozilla.org/integration/autoland/rev/cf4958e6d94562fcbb512f6b5caa15b0dc8b3fdd

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&searchStr=wrench&revision=0d50962a0bb9410b1351dc7bf1453618391eae30&selectedTaskRun=HZV_FW6FTMabqDwTh9Y1qg.0

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=311675951&repo=autoland&lineNumber=969

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d79a45fa9d67
Record profiler stats into captures to assist with debugging talos regressions. r=kvark

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/d79a45fa9d67