1656078 - java.lang.IllegalArgumentException: at org.mozilla.geckoview.GeckoRuntimeSettings.setFontSizeFactorInternal

Status: RESOLVED FIXED

(GeckoView :: General, defect, P1)

Description

[[ex-Mozilla] Agi Sferro | :agi]

from: https://github.com/mozilla-mobile/android-components/issues/7902

Caused by: java.lang.IllegalArgumentException: 
  at org.mozilla.geckoview.GeckoRuntimeSettings.setFontSizeFactorInternal (GeckoRuntimeSettings.java:6)
  at org.mozilla.geckoview.GeckoFontScaleListener.onSystemFontScaleChange (GeckoFontScaleListener.java:3)
  at org.mozilla.geckoview.GeckoFontScaleListener.start (GeckoFontScaleListener.java:6)
  at org.mozilla.geckoview.GeckoFontScaleListener.onEnabledChange (GeckoFontScaleListener.java:3)
  at org.mozilla.geckoview.GeckoFontScaleListener.setEnabled (GeckoFontScaleListener.java:3)
  at org.mozilla.geckoview.GeckoRuntimeSettings.setAutomaticFontSizeAdjustment (GeckoRuntimeSettings.java:1)
  at mozilla.components.browser.engine.gecko.GeckoEngine$settings$1.setAutomaticFontSizeAdjustment (GeckoEngine.kt:1)
  at mozilla.components.browser.engine.gecko.GeckoEngine.<init> (GeckoEngine.kt:25)
  at org.mozilla.fenix.components.Core$engine$2.invoke (Core.kt:15)

Comment 1

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1656078 - Handle negative FONT_SCALE values.

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

Just saw this in Android being handled too (mapping < 0 to 1.0):
https://cs.android.com/android/platform/superproject/+/master:frameworks/base/core/java/android/provider/Settings.java;l=3033-3037;drc=957f0a5285b20fdfde96278070ec19633516ebf9

Comment 3

[[ex-Mozilla] Agi Sferro | :agi]

(In reply to Sebastian Kaspari (:sebastian; :pocmo) from comment #2)

Just saw this in Android being handled too (mapping < 0 to 1.0):
https://cs.android.com/android/platform/superproject/+/master:frameworks/base/core/java/android/provider/Settings.java;l=3033-3037;drc=957f0a5285b20fdfde96278070ec19633516ebf9

Yes newer Androids do this. This is a problem only on older androids (5.x something I think) I checked the source code.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e7c2dd431fa
Handle negative FONT_SCALE values. r=owlish

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/4e7c2dd431fa