1656117 - Touching nsRefreshDriver.h rebuilds the world

Status: RESOLVED FIXED

(Core :: Web Painting, defect)

Description

[Markus Stange [:mstange]]

It would be great if we could reduce the build time cost of changing nsRefreshDriver.h.

My naive guess would be that the biggest hit comes from the #include in nsGlobalWindowInner.h, and I don't see any mention of "RefreshDriver" in that file.

Comment 1

[Simon Giesecke [:sg] [he/him]]

nsGlobalWindowInner.h must include nsRefreshDriver.h for nsAPostRefreshObserver, which might be moved to a separate header file to resolve this, as it does not have any further dependencies.

Comment 2

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1656117 - Reduce include dependencies on nsRefreshDriver.h. r=mstange

The abstract observer base classes are moved to a separate header file
nsRefreshObservers.h and the includes are adjusted accordingly.

Some method implementations are moved to the corresponding implementation files
to avoid the need to include the nsRefreshDriver.h file in the header.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c199c6518db4
Reduce include dependencies on nsRefreshDriver.h. r=mstange

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/c199c6518db4