1656281 - Stretching items in a grid container doesn't work if there's no aspect ratio.

Status: RESOLVED FIXED

(Core :: Layout, defect, P2)

Description

[Emilio Cobos Álvarez (:emilio)]

http://crisal.io/tmp/stretch-no-ratio.html is a test-case where we shouldn't show red but we do.

This blocks cleaning up iframes to use proper replaced element computation because <xul:browser> needs to stretch to fill its container.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1656281 - Allow to stretch items with no intrinsic ratio. r=mats

There's no reason this shouldn't work per the grid spec.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1656281 - Remove some outdated condition on the meaning of align/justify-self: normal on grid items without aspect ratio. r=mats

This matches the behavior of other browsers, and the spec as far as I
can tell.

https://drafts.csswg.org/css-grid/#grid-item-sizing no longer mentions
'stretch' from the definition of 'normal'.

Depends on D85435

Comment 3

[Mats Palmgren (inactive)]

Attachment: additional tests

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/330c4fd5259d
Allow to stretch items with no intrinsic ratio. r=mats

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/24895 for changes under testing/web-platform/tests

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/330c4fd5259d

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot