Closed Bug 1656316 Opened 4 years ago Closed 4 years ago

Exceptions in SeaMonkey Data Manager with content preferences

Categories

(SeaMonkey :: Preferences, enhancement)

enhancement

Tracking

(seamonkey2.53+ fixed, seamonkey2.57esr? affected)

RESOLVED FIXED
seamonkey 2.79
Tracking Status
seamonkey2.53 + fixed
seamonkey2.57esr ? affected

People

(Reporter: frg, Assigned: frg)

References

Details

(Whiteboard: SM2.53.4)

Attachments

(1 file)

While testing Bug 1655362 I found some serious problems with managing content prefs. For non host prefs (* domain) an error would be logged during checking when the pref contains a null pref. Also displaying them would fail because a null comparision did throw because the displayhost was not set for * content prefs.

Whiteboard: SM2.53.4

[Approval Request Comment]
Regression caused by (bug #): --
User impact if declined: contnet prefs are missing
Testing completed (on m-c, etc.): 2.53.5
Risk to taking this patch (and alternatives if risky): none already broken
String changes made by this patch: --

Attachment #9167110 - Flags: review?(iann_bugzilla)
Attachment #9167110 - Flags: approval-comm-release?
Attachment #9167110 - Flags: approval-comm-esr60?
Comment on attachment 9167110 [details] [diff] [review]
1656316-nullhost-2534.patch

>+++ b/suite/components/dataman/content/dataman.js
>+  getDomainFromHostWithCheck: function domain_getDomainFromHostWithCheck(aHost) {
>+    // global content pref changes and others might not have a host.
Nit: Global

r/a=me
Attachment #9167110 - Flags: review?(iann_bugzilla)
Attachment #9167110 - Flags: review+
Attachment #9167110 - Flags: approval-comm-release?
Attachment #9167110 - Flags: approval-comm-release+
Attachment #9167110 - Flags: approval-comm-esr60?
Attachment #9167110 - Flags: approval-comm-esr60+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/21d764fcb87a
Allow null host in data manager check and always set displayhost. r=IanN

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: