Exceptions in SeaMonkey Data Manager with content preferences
Categories
(SeaMonkey :: Preferences, enhancement)
Tracking
(seamonkey2.53+ fixed, seamonkey2.57esr? affected)
People
(Reporter: frg, Assigned: frg)
References
Details
(Whiteboard: SM2.53.4)
Attachments
(1 file)
2.68 KB,
patch
|
iannbugzilla
:
review+
iannbugzilla
:
approval-comm-release+
iannbugzilla
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
While testing Bug 1655362 I found some serious problems with managing content prefs. For non host prefs (* domain) an error would be logged during checking when the pref contains a null pref. Also displaying them would fail because a null comparision did throw because the displayhost was not set for * content prefs.
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 1•4 years ago
|
||
[Approval Request Comment]
Regression caused by (bug #): --
User impact if declined: contnet prefs are missing
Testing completed (on m-c, etc.): 2.53.5
Risk to taking this patch (and alternatives if risky): none already broken
String changes made by this patch: --
Comment on attachment 9167110 [details] [diff] [review] 1656316-nullhost-2534.patch >+++ b/suite/components/dataman/content/dataman.js >+ getDomainFromHostWithCheck: function domain_getDomainFromHostWithCheck(aHost) { >+ // global content pref changes and others might not have a host. Nit: Global r/a=me
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/21d764fcb87a
Allow null host in data manager check and always set displayhost. r=IanN
Assignee | ||
Comment 4•4 years ago
|
||
Target 2.53.4 beta 1
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/c8ab804b6959de5797fd82435b92f6e9a0dcc882
Description
•