Closed
Bug 1656469
Opened 5 years ago
Closed 9 months ago
CacheIRWriter::loadArgumentFixedSlot's flags argument should not be optional
Categories
(Core :: JavaScript Engine: JIT, task, P2)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
136 Branch
| Tracking | Status | |
|---|---|---|
| firefox136 | --- | fixed |
People
(Reporter: jandem, Assigned: anba)
References
Details
Attachments
(1 file)
The optional argument is a footgun because when optimizing a constructor call, the argument needs to be passed and the default will (silently) do the wrong thing.
|
Assignee | |
Comment 1•9 months ago
|
||
Explicitly pass CallFlags(CallFlags::Standard) for the few cases where we
currently use the default argument.
|
||
Updated•9 months ago
|
Assignee: nobody → andrebargull
Status: NEW → ASSIGNED
Pushed by andre.bargull@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/59577dc2ddb2
Make CallFlags argument mandatory. r=jandem
|
||
Comment 3•9 months ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
status-firefox136:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 136 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•