165647 - Warnings dude!

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect, P5)

Description

[John Keiser (jkeiser)]

Dude!  You have warnings!  Some are intractable but one or two are particularly
nasty looking ones too--bite your head off, man.

Comment 1

[John Keiser (jkeiser)]

> 1. content/html/content/src/nsFormSubmission.cpp:1481 (See build log excerpt)
> Unused variable `nsresult rv'
> 
> 1479   }
> 1480 
> 1481   nsresult rv = mFormProcessor->ProcessValue(aSource, tmpNameStr, *retval);
> 1482   NS_ASSERTION(NS_SUCCEEDED(rv), "Unable to Notify form process > observer");
> 1483 }

Fake.

> 2. content/html/content/src/nsHTMLFormElement.cpp:359 (See build log excerpt)
`class nsFormControlEnumerator' has virtual functions but non-virtual destructor
>
> 357   nsSupportsArray mNotInElementsSorted;
> 358   PRUint32 mNotInElementsIndex;
> 359 };

Real and somewhat bad (sorta).

> 3. content/html/content/src/nsHTMLIFrameElement.cpp:105 (See build log excerpt)
...was hidden by `nsHTMLIFrameElement::SetAttr(int, nsIAtom *, const nsAString
&, int)'
> 
> 103                              nsAString& aResult) const;
> 104 NS_IMETHOD SetAttr(PRInt32 aNameSpaceID, nsIAtom* aName,
> 105                    const nsAString& aValue, PRBool aNotify) {
> 106   nsresult rv = nsGenericHTMLContainerElement::SetAttr(aNameSpaceID, aName,
> 107                                                        aValue, aNotify);

Real but not affecting current code at all; hard to resolve; see bug 179028.

Comment 2

[John Keiser (jkeiser)]

Attachment: Patch for virtual destructor warning (checked in)

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 105645 [details] [diff] [review]
Patch for virtual destructor warning (checked in)

this is the one I cared about... sr=bzbarsky

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 105645 [details] [diff] [review]
Patch for virtual destructor warning (checked in)

r=dmose

Comment 5

[John Keiser (jkeiser)]

Leaving bug open so I can use it for other warnings later.