Closed Bug 1656476 Opened 4 years ago Closed 4 years ago

Implement "about:shortcuts" view with a list of current keyboard bindings

Categories

(Firefox :: Keyboard Navigation, enhancement)

enhancement

Tracking

()

RESOLVED DUPLICATE of bug 492557

People

(Reporter: anatoli, Unassigned)

Details

Would be nice to see programmatically constructed list of active keyboard combinations at about:shortcuts right inside of Firefox. Regardless of design decisions on how to customize them or let extensions register their own.

Blocks: 588710
Summary: Implement "about:shortcuts" view with a list os current keyboard bindings → Implement "about:shortcuts" view with a list of current keyboard bindings
No longer blocks: 588710
Status: UNCONFIRMED → RESOLVED
Closed: 4 years ago
Resolution: --- → DUPLICATE

@:Gijs HUD?

(In reply to Anatoli Babenia from comment #2)

@:Gijs HUD?

"head up display". Like "overlay" or "popup" or whatever. I think the original idea is for it to come up when you press "?" or similar, as it does on many websites.

Yes, I think it is not really appropriate to show native browser shortcuts in da HUD. They will meddle with website shortcuts if the HUD is bound to ? key. I would first implement about:shortcuts list as it is much less work, and then think about the interface to detect conflict/overrrides and interface to show them (da HUD).

(In reply to Anatoli Babenia from comment #4)

Yes, I think it is not really appropriate to show native browser shortcuts in da HUD. They will meddle with website shortcuts if the HUD is bound to ? key.

This is covered by the outdated WIP patch (it's bound to a different shortcut).

I would first implement about:shortcuts list as it is much less work

This is really just not the case. Much easier to get the list of shortcuts and display it in the same document where they shortcut keys exist.

Either way, no point having 2 bugs open for 2 different ways of doing exactly the same thing, namely displaying a list of shortcuts.

Is there a misunderstanding? There is no document in this report. The report is about listing all Firefox native shortcuts, independent of the current page.

(In reply to Anatoli Babenia from comment #6)

Is there a misunderstanding? There is no document in this report. The report is about listing all Firefox native shortcuts, independent of the current page.

The browser window is a document; about:shortcuts would be a page loaded in a tab, and so a different document. The "Firefox native shortcuts" live in the browser window document, so getting a list of them from the about:shortcuts document is more complicated than it is from within the browser window document.

Right. That's why for about:shortcuts the Firefox API should expose API to query all possible document types together with their assigned shortcuts. If you mean that everything in Firefox is a document.

I can't really understand this document abstraction. For example, what is the name or id of the document that includes Ctrl+O shortcut that opens file?

(In reply to Anatoli Babenia from comment #8)

If you mean that everything in Firefox is a document.

Not "everything", no...

I can't really understand this document abstraction.

It's not an abstraction as much as a reality: https://searchfox.org/mozilla-central/source/browser/base/content/browser.xhtml is the main browser window. You can open view-source:chrome://browser/content/browser.xhtml to see the finished thing that is used to render the browser window in which you're viewing this bug report. Toolbars, menus, the address bar - all of it. So too the shortcuts.

About pages get their own documents, e.g. https://searchfox.org/mozilla-central/source/browser/components/aboutconfig/content/aboutconfig.html is about:config .

For example, what is the name or id of the document that includes Ctrl+O shortcut that opens file?

The browser.xhtml one.

You can open view-source:chrome://browser/content/browser.xhtml to see the finished thing that is used to render the browser window in which you're viewing this bug report. Toolbars, menus, the address bar - all of it. So too the shortcuts.

Is there a list of other pages that contain shortcuts that are relevant to user?

You need to log in before you can comment on or make changes to this bug.