Closed
Bug 1656508
Opened 5 years ago
Closed 5 years ago
Fix blocking of default top sites with %YYYYMMDDHH% in their URL
Categories
(Firefox :: Top Sites, defect, P2)
Firefox
Top Sites
Tracking
()
People
(Reporter: dao, Assigned: dao)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
47 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
While working on bug 1653934, I just realized that removing these kind of tiles won't work because removing a tile adds its URL to a blocklist but in this case the URL changes regularly.
|
Assignee | |
Updated•5 years ago
|
Points: --- → 3
|
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Iteration: --- → 82.1 - Aug 24 - Sep 6
|
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Updated•5 years ago
|
Iteration: 82.1 - Aug 24 - Sep 6 → 82.2 - Sep 7 - Sep 20
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/276576a8537f
Fix blocking of default top sites with %YYYYMMDDHH% in their URL. r=mikedeboer
|
|
Assignee | |
Comment 3•5 years ago
|
||
Comment on attachment 9174897 [details]
Bug 1656508 - Fix blocking of default top sites with %YYYYMMDDHH% in their URL. r=mikedeboer
Beta/Release Uplift Approval Request
- User impact if declined: This is needed for moving top sites to remote settings in Firefox 81, in particular the Amazon link where we want to use %YYYYMMDDHH%.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Simple fix, and the feature is currently disabled by default.
- String changes made/needed:
Attachment #9174897 -
Flags: approval-mozilla-beta?
|
||
Comment 4•5 years ago
|
||
Comment on attachment 9174897 [details]
Bug 1656508 - Fix blocking of default top sites with %YYYYMMDDHH% in their URL. r=mikedeboer
Approved for 81.0b9.
Attachment #9174897 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
|
|
||
Comment 5•5 years ago
|
||
| bugherder uplift | ||
status-firefox81:
--- → fixed
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox82:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
|
|
||
Comment 7•5 years ago
|
||
I verified this issue using 82.0a1 (2020-09-15) and 81.0 on macOS 10.13 and Windows 10 x64.
Adrian could you help me with Ubuntu verification?
Flags: needinfo?(adrian.florinescu)
|
||
Comment 8•5 years ago
|
||
Verified on Ubuntu 20.04 as well with 82.0a1 (2020-09-16) and 81.0. Based on comment 7 and comment 8, marking as verified.
Status: RESOLVED → VERIFIED
Flags: needinfo?(adrian.florinescu)
You need to log in
before you can comment on or make changes to this bug.
Description
•