1656564 - UI: Link for download of Themes leads to Themes for Thunderbird

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Rainer Bielefeld]

Steps how to reproduce with unzipped installer of unofficial (by wg9s) en-US SeaMonkey 2.53.5 beta 1 pre Mozilla/5.0 (NT 6.1; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0 Build 20200727210001 (Default Classic Theme) on German WIN7 64bit:

1. Launch Browser
2. Menu ˋTools → Add-Ons Manager → Appearanceˊ
   » List with installed Themes will appear
3. At the to of the page click "Choose from Thousands of Themes"
   » Add-Ons repository opens in Browser
   Expected: SeaMonkey Themes list
   Actual: "Featured Extensions" page 😥

Additional Information:

a) Link should lead to SeaMonkey Featured Extensions Themes page (but that one is empty) or even better to https://addons.thunderbird.net/en-US/seamonkey/search/?q=themes (or similar)
b) I did not find an obvious DUP in this Query
c) All the same with German UI

Comment 1

[Rainer Bielefeld]

Still REPRODUCIBLE with installation of unofficial (by wg9s) De SeaMonkey 2.53.14 beta 1 pre Mozilla/5.0 (NT 6.1; Win64; x64; rv:68.0) Gecko/20100101 Firefox/68.0 Build 20220801210005 (Same with normal user Profile and newly created User Profile Default Classic Theme) on German WIN10 64bit

Comment 2

[Matt A. Tobin [:nsITobin]]

I cannot reproduce this in current SeaMonkey 2.53 as it seems to have been fixed and correct urls are provided to the prefs.

Comment 3

[Frank-Rainer Grahl (:frg)]

It is still a problem:
http://xr.thereisonlyxul.org/seamonkey-2.53/source/comm/suite/app/profile/suite-prefs.js#619
http://xr.thereisonlyxul.org/seamonkey-2.53/source/toolkit/mozapps/extensions/content/extensions.js#2792

Seems the source is dropped and always routed to Thunderbird: "https://addons.thunderbird.net/%LOCALE%/thunderbird/themes/?src=seamonkey"

Comment 4

[Matt A. Tobin [:nsITobin]]

I see, batting a thousand.. anyway, Themes to TB's AMO was personas. Yeah Thunderbird removed all personas from the modified Add-ons Server they run. So personas as "themes" is routed to "static-themes" and either they did a hardcode or the software is being "smart" and routing to the only application on that server with static themes. AMO historically has had all kinds of URL rewriting stuff pile up and Thunderbird's server still has much of it vs AMO for Firefox today.

So we need to alter the URL to be https://addons.thunderbird.net/%LOCALE%/seamonkey/complete-themes/ or add static-theme support cause as a webextension there is no targetApplication and Thunderbird static-themes would work.

Comment 5

[Matt A. Tobin [:nsITobin]]

Attachment: 1656564-fix-themes-browseURL.patch

Comment 6

[Matt A. Tobin [:nsITobin]]

Attachment: 1656564-fix-themes-browseURL-fixed-header.patch

Fixed patch header

Comment 7

[Frank-Rainer Grahl (:frg)]

should be in he next 2.53.20b1 pre for testing

Comment 8

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9422099 [details] [diff] [review]
1656564-fix-themes-browseURL-fixed-header.patch

Works great. r/a+ Thanks.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d3fbe551aff7
Link to the complete SeaMonkey themes on the TB add-ons site. r=frg