1656596 - Crash in [@ WebProgressListenerToPromise::OnStateChange]

Status: RESOLVED FIXED

(Core :: Printing: Output, defect)

Description

[u608768]

This bug is for crash report bp-962d7f8b-72c4-4bbc-87d8-3f3f30200731.

Top 10 frames of crashing thread:

0 xul.dll WebProgressListenerToPromise::OnStateChange dom/base/nsFrameLoader.cpp:3131
1 xul.dll mozilla::layout::RemotePrintJobParent::RecvStateChange layout/printing/ipc/RemotePrintJobParent.cpp:198
2 xul.dll mozilla::layout::PRemotePrintJobParent::OnMessageReceived ipc/ipdl/PRemotePrintJobParent.cpp:345
3 xul.dll mozilla::dom::PContentParent::OnMessageReceived ipc/ipdl/PContentParent.cpp:6582
4 xul.dll mozilla::ipc::MessageChannel::DispatchMessage ipc/glue/MessageChannel.cpp:2074
5 xul.dll mozilla::ipc::MessageChannel::MessageTask::Run ipc/glue/MessageChannel.cpp:1953
6 xul.dll mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal xpcom/threads/TaskController.cpp:512
7 xul.dll mozilla::detail::RunnableFunction<`lambda at /builds/worker/checkouts/gecko/xpcom/threads/TaskController.cpp:83:7'>::Run xpcom/threads/nsThreadUtils.h:577
8 xul.dll nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1234
9 xul.dll mozilla::ipc::MessagePump::Run ipc/glue/MessagePump.cpp:87

Started in build 20200730215452. The assertion was added in bug 1655746.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1656596 - Add another missing null-check in our printing code. r=jwatt

This code needs fuzzing desperately...

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 9167412 [details]
Bug 1656596 - Add another missing null-check in our printing code. r=jwatt

Beta/Release Uplift Approval Request

• User impact if declined: crashes while printing
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Adds a null-check. Bug 1655746 added an assertion, but this would crash before that as well.
• String changes made/needed: none

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/07803833e05c
Add another missing null-check in our printing code. r=nordzilla

Comment 4

[Julien Cristau [:jcristau]]

Comment on attachment 9167412 [details]
Bug 1656596 - Add another missing null-check in our printing code. r=jwatt

crash fix, approved for 80.0b3

Comment 5

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/05a90f1071ad

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/07803833e05c