1656611 - Remove objdir support from `virtualenv_packages.txt` handling

Status: RESOLVED FIXED

(Firefox Build System :: General, task)

Comment 1

[Ricky Stewart]

Attachment: Bug 1656611 - Remove `objdir` support from `virtualenv_packages.txt` handling

I noticed that the objdir:build entry in build/virtualenv_packages.txt entry was apparently unused. This originates from bug 841713, seven years ago, when the objdir handling was introduced. Today, this doesn't appear to be serving a purpose. There is no Python library in my $objdir/build directory; nor can I see anything in build/moz.build or any related files suggesting one could ever appear. I can only assume this feature has outlived its usefulness, so delete it and the relevant in-tree support.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/760fc38c793b
Remove `objdir` support from `virtualenv_packages.txt` handling r=mhentges,froydnj

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

Backed out changeset 760fc38c793b (bug 1656611) for doc failure complaining about virtualenv_root

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&fromchange=760fc38c793b5557e70416f10e6e2d2e9edeb903&tochange=d9ca50769687fe2176acf0660e1e4ed420816c4b&searchStr=doc&selectedTaskRun=MaiTcwtiRrqQWEcYXp2nDA.0

Backout link: https://hg.mozilla.org/integration/autoland/rev/d9ca50769687fe2176acf0660e1e4ed420816c4b

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=312405305&repo=autoland&lineNumber=106

[vcs 2020-08-07T15:49:41.356Z] TinderboxPrint:<a href=https://us-east-1.hgmointernal.net/integration/autoland/rev/760fc38c793b5557e70416f10e6e2d2e9edeb903 title='Built from autoland revision 760fc38c793b5557e70416f10e6e2d2e9edeb903'>760fc38c793b5557e70416f10e6e2d2e9edeb903</a>
[setup 2020-08-07T15:49:41.356Z] GECKO_PATH is /builds/worker/checkouts/gecko
[task 2020-08-07T15:49:41.356Z] executing ['bash', '-cx', './mach doc --outdir docs-out --no-open --no-serve --archive']in /builds/worker/checkouts/gecko
[task 2020-08-07T15:49:41.358Z] + ./mach doc --outdir docs-out --no-open --no-serve --archive
[task 2020-08-07T15:49:42.558Z] Error running mach:
[task 2020-08-07T15:49:42.558Z] 
[task 2020-08-07T15:49:42.558Z]     ['doc', '--outdir', 'docs-out', '--no-open', '--no-serve', '--archive']
[task 2020-08-07T15:49:42.558Z] 
[task 2020-08-07T15:49:42.558Z] The error occurred in the implementation of the invoked mach command.
[task 2020-08-07T15:49:42.558Z] 
[task 2020-08-07T15:49:42.558Z] This should never occur and is likely a bug in the implementation of that
[task 2020-08-07T15:49:42.558Z] command.
[task 2020-08-07T15:49:42.558Z] You can invoke |./mach busted| to check if this issue is already on file. If it
[task 2020-08-07T15:49:42.558Z] isn't, please use |./mach busted file doc| to report it. If |./mach busted| is
[task 2020-08-07T15:49:42.558Z] misbehaving, you can also inspect the dependencies of bug 1543241.
[task 2020-08-07T15:49:42.558Z] 
[task 2020-08-07T15:49:42.558Z] If filing a bug, please include the full output of mach, including this error
[task 2020-08-07T15:49:42.558Z] message.
[task 2020-08-07T15:49:42.558Z] 
[task 2020-08-07T15:49:42.558Z] The details of the failure are as follows:
[task 2020-08-07T15:49:42.558Z] 
[task 2020-08-07T15:49:42.558Z] AttributeError: 'NoneType' object has no attribute 'virtualenv_root'
[task 2020-08-07T15:49:42.558Z] 
[task 2020-08-07T15:49:42.558Z]   File "/builds/worker/checkouts/gecko/tools/moztreedocs/mach_commands.py", line 84, in build_docs
[task 2020-08-07T15:49:42.558Z]     os.path.dirname(self._virtualenv_manager.virtualenv_root),
[taskcluster 2020-08-07 15:49:43.827Z] === Task Finished ===
[taskcluster 2020-08-07 15:49:43.912Z] Artifact "public/docs.tar.gz" not found at "/builds/worker/checkouts/gecko/docs-out/main.tar.gz"
[taskcluster 2020-08-07 15:49:44.024Z] Unsuccessful task run with exit code: 1 completed in 76.773 seconds

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/44bb58dd0971
Remove `objdir` support from `virtualenv_packages.txt` handling r=mhentges,froydnj

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/44bb58dd0971