1656631 - Multistage about:welcome - Make static fixed sites in Import screen as default experience

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Punam Dahiya [:pdahiya]]

For the default onboarding experience, graduate the “static” branch import experience as default experience in Fx 80

See Recommendation in Summary
https://docs.google.com/document/d/1YdgxU8ffs6xZxaTzqaKWTRuhUqmZUtz-WoHqCyhI4Jk/edit#heading=h.fc3kf1y0jr96

Comment 1

[Punam Dahiya [:pdahiya]]

(In reply to Punam Dahiya [:pdahiya] from comment #0)

For the default onboarding experience, graduate the “static” branch import experience as default experience in Fx 80

See Recommendation in Summary
https://docs.google.com/document/d/1YdgxU8ffs6xZxaTzqaKWTRuhUqmZUtz-WoHqCyhI4Jk/edit#heading=h.fc3kf1y0jr96

NI Aaron to check if static topsites should be grouped together and shown background highlight on hover similar to importable sites

Comment 2

[Punam Dahiya [:pdahiya]]

Triaging as P1 and uplift candidate

Comment 3

[Punam Dahiya [:pdahiya]]

[Tracking Requested - why for this release]:
Based on recommendation from 78 v1 experiment, we would like to switch Import screen default experience to show fixed top sites by locale

Comment 4

[Punam Dahiya [:pdahiya]]

Attachment: Bug 1656631 - Multistage about:welcome - Make static sites in import screen as default experience

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f5a5061ddd82
Multistage about:welcome - Make static sites in import screen as default experience r=emcminn

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/f5a5061ddd82

Comment 7

[Robert Martin [:romartin], Ecosystem QA]

I have verified that the following static top sites are displayed as default experience on the "Import" slide from the "about:welcome" page, depending on the Firefox locale:

• For Firefox Nightly en-US (Build ID: 20200806033456), region "US", the following websites are displayed:
  - "https://www.youtube.com/", "https://www.facebook.com/", "https://www.amazon.com/", "https://www.reddit.com/" , "https://www.wikipedia.org/".
• For Firefox Nightly RU (Build ID: 20200806033456), region "RU", the following websites are displayed:
  - "https://vk.com/", "https://www.youtube.com/", "https://ok.ru/", "https://www.avito.ru/", "https://www.aliexpress.com/".

I've done the verification on Windows 10, macOS 10.15, and Ubuntu Linux 18.04.

Comment 8

[Punam Dahiya [:pdahiya]]

Comment on attachment 9168208 [details]
Bug 1656631 - Multistage about:welcome - Make static sites in import screen as default experience

Beta/Release Uplift Approval Request

• User impact if declined: Will not be able to implement recommendation from 78 v1 experiment and user will see dynamic pre-imported sites during onboarding flow
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: https://bugzilla.mozilla.org/show_bug.cgi?id=1656631#c7
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small patch that changes message id in JSON inside firefox.js
• String changes made/needed: none

Comment 9

[Julien Cristau [:jcristau]]

Comment on attachment 9168208 [details]
Bug 1656631 - Multistage about:welcome - Make static sites in import screen as default experience

approved for 80.0b6

Comment 10

[Julien Cristau [:jcristau]]

The change doesn't graft cleanly to beta, can you provide a rebased patch?

Comment 11

[Punam Dahiya [:pdahiya]]

Attachment: Bug 1656631 - Make static sites in import screen as default experience

Comment 12

[Punam Dahiya [:pdahiya]]

@jcristau please find attached patch rebased with beta in https://bugzilla.mozilla.org/show_bug.cgi?id=1656631#c11, thanks!

Comment 13

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/2ee35bfc90ee

Comment 14

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this enhancement and I can confirm that the static "Top Sites" are displayed on the "Import" slide of the "about:welcome" page.

Verified using the latest Firefox Beta (80.0b7 Build ID - 20200811133449) installed on Windows 10 x64, Mac 10.15, and Ubuntu 18.04 x64.