Closed Bug 1656631 Opened 6 months ago Closed 6 months ago

Multistage about:welcome - Make static fixed sites in Import screen as default experience

Categories

(Firefox :: Messaging System, enhancement, P1)

enhancement

Tracking

()

VERIFIED FIXED
81 Branch
Iteration:
81.1 - July 27 - Aug 09
Tracking Status
firefox80 + verified
firefox81 --- verified

People

(Reporter: pdahiya, Assigned: pdahiya)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

For the default onboarding experience, graduate the “static” branch import experience as default experience in Fx 80

See Recommendation in Summary
https://docs.google.com/document/d/1YdgxU8ffs6xZxaTzqaKWTRuhUqmZUtz-WoHqCyhI4Jk/edit#heading=h.fc3kf1y0jr96

(In reply to Punam Dahiya [:pdahiya] from comment #0)

For the default onboarding experience, graduate the “static” branch import experience as default experience in Fx 80

See Recommendation in Summary
https://docs.google.com/document/d/1YdgxU8ffs6xZxaTzqaKWTRuhUqmZUtz-WoHqCyhI4Jk/edit#heading=h.fc3kf1y0jr96

NI Aaron to check if static topsites should be grouped together and shown background highlight on hover similar to importable sites

Flags: needinfo?(abenson)

Triaging as P1 and uplift candidate

Assignee: nobody → pdahiya
Iteration: --- → 81.1 - July 27 - Aug 09
Priority: -- → P1

[Tracking Requested - why for this release]:
Based on recommendation from 78 v1 experiment, we would like to switch Import screen default experience to show fixed top sites by locale

Pushed by pdahiya@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f5a5061ddd82
Multistage about:welcome - Make static sites in import screen as default experience r=emcminn
Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch

I have verified that the following static top sites are displayed as default experience on the "Import" slide from the "about:welcome" page, depending on the Firefox locale:

I've done the verification on Windows 10, macOS 10.15, and Ubuntu Linux 18.04.

Status: RESOLVED → VERIFIED

Comment on attachment 9168208 [details]
Bug 1656631 - Multistage about:welcome - Make static sites in import screen as default experience

Beta/Release Uplift Approval Request

  • User impact if declined: Will not be able to implement recommendation from 78 v1 experiment and user will see dynamic pre-imported sites during onboarding flow
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: https://bugzilla.mozilla.org/show_bug.cgi?id=1656631#c7
  • List of other uplifts needed: none
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Small patch that changes message id in JSON inside firefox.js
  • String changes made/needed: none
Attachment #9168208 - Flags: approval-mozilla-beta?
Flags: qe-verify+
Flags: needinfo?(abenson)

Comment on attachment 9168208 [details]
Bug 1656631 - Multistage about:welcome - Make static sites in import screen as default experience

approved for 80.0b6

Attachment #9168208 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

The change doesn't graft cleanly to beta, can you provide a rebased patch?

Flags: needinfo?(pdahiya)

@jcristau please find attached patch rebased with beta in https://bugzilla.mozilla.org/show_bug.cgi?id=1656631#c11, thanks!

Flags: needinfo?(pdahiya)
QA Whiteboard: [qa-triaged]

I have verified this enhancement and I can confirm that the static "Top Sites" are displayed on the "Import" slide of the "about:welcome" page.

Verified using the latest Firefox Beta (80.0b7 Build ID - 20200811133449) installed on Windows 10 x64, Mac 10.15, and Ubuntu 18.04 x64.

Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.