Closed
Bug 1656831
Opened 4 years ago
Closed 4 years ago
Optimize Array pop/shift in CacheIR and Warp
Categories
(Core :: JavaScript Engine: JIT, task, P2)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
81 Branch
| Tracking | Status | |
|---|---|---|
| firefox81 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
No description provided.
|
Assignee | |
Comment 1•4 years ago
|
||
Optimizes pop/shift on packed arrays. A new implementation was added that's used
by both CacheIR and Warp. This version is simpler, also supports pre-barriers,
and doesn't need a VM call as fallback.
|
|
Assignee | |
Comment 2•4 years ago
|
||
This makes it possible for the next patch to check for non-extensible objects
as part of the other ObjectElements flags checks, instead of having to check
the BaseShape flag separately.
|
||
Updated•4 years ago
|
Attachment #9167614 -
Attachment description: Bug 1656831 - Optimize Array.prototype.{pop,shift} in CacheIR and Warp. r?anba! → Bug 1656831 part 2 - Optimize Array.prototype.{pop,shift} in CacheIR and Warp. r?anba!
Pushed by jdemooij@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3965e512a174 part 1 - Add NOT_EXTENSIBLE flag to ObjectElements. r=anba https://hg.mozilla.org/integration/autoland/rev/bbdc75a42a13 part 2 - Optimize Array.prototype.{pop,shift} in CacheIR and Warp. r=anba
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/3965e512a174
https://hg.mozilla.org/mozilla-central/rev/bbdc75a42a13
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox81:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•