1656852 - Can't click on link inside Console > Network > Headers

Status: RESOLVED FIXED

(DevTools :: Netmonitor, enhancement, P3)

Description

[maxime.defaucheux]

Attachment: Capture d’écran 2020-08-03 à 11.16.31.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:79.0) Gecko/20100101 Firefox/79.0

Steps to reproduce:

I'm a web developer, so I use Firefox console everyday.
Each time I get an error from Symfony I need to click on a link provided by Symfony inside headers.
So basically, the only thing I do is opening my console and going to Network tab.
I'm using Mac OS 10.15.6

Actual results:

There, when I click on any link, nothing happens.

Expected results:

When I click on a link, it should open the link (preferably with a new tab).

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Hubert Boma Manilla (:bomsy)]

Thanks for reporting!

This is a good idea.

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Looks like the click event is lost somewhere or not handled properly when the click happens on a link

I just found this place where we call stopPropagation in the Tree component
https://searchfox.org/mozilla-central/rev/36aa22c7ea92bd3cf7910774004fff7e63341cf5/devtools/client/shared/components/tree/TreeView.js#471

Also here is the StringRep component that does the "linkifying" of text (auto converting text to <a>s)
Perhaps we are not handling clicking on those links properly?
https://searchfox.org/mozilla-central/rev/36aa22c7ea92bd3cf7910774004fff7e63341cf5/devtools/client/shared/components/reps/reps/string.js#212

Honza

Comment 4

[Angelina]

Attachment: Request headers link

Comment 5

[Angelina]

Hello, Honza!

So, I have done some research and found out that OpenLink and isInContentPage props in the component
https://searchfox.org/mozilla-central/rev/36aa22c7ea92bd3cf7910774004fff7e63341cf5/devtools/client/shared/components/reps/reps/string.js#212
are undefined and that's why links don't have href and onclick attributes. I think this can be a reason too?

Comment 6

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Thanks for the update!

Yes, this could be a problem too. How come they are undefined? Is the value lost along the way or it's never set properly?

Honza

Comment 7

[Angelina]

Attachment: Bug 1656852 click on a link in Network Headers Panel r?honza

Depends on D129407

Comment 8

[Angelina]

Hello, Honza!

There is some workaround for StringRep in HeadersPanel
https://searchfox.org/mozilla-central/source/devtools/client/netmonitor/src/components/request-details/HeadersPanel.js#453

So openLink was not set there, I tried to use OpenContentLink function from
https://searchfox.org/mozilla-central/source/devtools/client/shared/link.js#59

So now you can open Referer link in Netmonitor Headers Panel. Please check the patch ;)

Comment 9

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Angelina from comment #8)

So openLink was not set there, I tried to use OpenContentLink function from
https://searchfox.org/mozilla-central/source/devtools/client/shared/link.js#59

Angelina, do you have a patch you could share?
Don't worry if it isn't finished. I just want to try whatever you've tried. Thank you

Honza

Comment 10

[Angelina]

(In reply to Angelina from comment #7)

Created attachment 9247600 [details]
Bug 1656852 click on a link in Network Headers panel r?honza

Depends on D129407

Honza, yes, this one ;)

Comment 11

[Angelina]

Sure, it is above my comment :)

https://bugzilla.mozilla.org/attachment.cgi?id=9247600

Comment 12

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: patch

Ah, yes, sorry :-)

I was testing the patch and I found and alternative solution

• There is already an openLink method in the app.js file (the main file for the NetworkMonitor)
• The openLink property is passed to all side panels alredy
• If I pass the openLink prop to the StringRep explicitly it's called but crashes on "top.openWebLinkIn" is undefined
• Btw. It's a bit suprising that openLink wasn't passed into the StringRep already...
• Calling the shared openContentLink from within the openLink in app.js seems to be solving the problem (and is used everywhere in the Netmonitor I think)

Bomsy, what do you think?

Comment 13

[Angelina]

Hello, Bomsy! Please review. Should I update my patch?

Comment 14

[Hubert Boma Manilla (:bomsy)]

Calling the shared openContentLink from within the openLink in app.js seems to be solving the problem (and is used everywhere in the Netmonitor I think)

I agree, this is the way to go

The openLink property is passed to all side panels already

I'm wondering if we can get rid of passing openLink through all these components as they do not seem to be used a lot. We can just lazily import it into the component when needed, but this is a follow up.

Thanks

Comment 15

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Hubert Boma Manilla (:bomsy) from comment #14)

I'm wondering if we can get rid of passing openLink through all these components as they do not seem to be used a lot. We can just lazily import it into the component when needed, but this is a follow up.

Yes, good point. I vote doing this (together with analysis) in a separate bug.

Comment 16

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:angelinasen1, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 17

[Hubert Boma Manilla (:bomsy)]

This to ok to land. I've pushed it.

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/531de34ab726
click on a link in Network Headers Panel r=Honza,bomsy

Comment 19

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/531de34ab726