1656858 - Assertion failure: focusedWindow (BrowsingContext should always have a window here.) when session-restoring on a debug build

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P2)

Description

[Emilio Cobos Álvarez [:emilio]]

Just session-restoring, switching focused windows with Alt+Tab back to my terminal, then switching back to firefox and pressing Enter to restore the session.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

https://pernos.co/debug/4hvguMmzHQ9ClucfTwEjRg/index.html is a pernosco session with this assert hit locally.

Comment 2

[Jens Stutte [:jstutte]]

This looks very similar to bug 1653904, though here we assert at least.

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Yeah, this is basically the debug-build version of the crash in bug 1653904.

Comment 4

[Henri Sivonen (:hsivonen)]

Attachment: Bug 1656858 - Obtain principals differently in the parent process in SetFocusInner().

Comment 5

[Henri Sivonen (:hsivonen)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=814414f0761f698d22428ceb0e4f61e98f906097

Comment 6

[Jens Stutte [:jstutte]]

Hi Henri, can we dupe bug 1653904 to this then?

Comment 8

[Henri Sivonen (:hsivonen)]

Yes, it looks like a duplicate of this one.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f212f223bee3
Obtain principals differently in the parent process in SetFocusInner(). r=farre

Comment 10

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/f212f223bee3

Comment 11

[Julien Cristau [:jcristau]]

Please request beta uplift when you get a chance.

Comment 12

[Henri Sivonen (:hsivonen)]

Comment on attachment 9167669 [details]
Bug 1656858 - Obtain principals differently in the parent process in SetFocusInner().

Beta/Release Uplift Approval Request

• User impact if declined: Causes some crashes, presumably especially at session restore time. (Verified in Nightly in the sense of crash reports stopping, not by manual testing.)
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Should be low risk, because this performs the same operation on principals as before but merely obtains them in a different way in the parent process.
• String changes made/needed: None

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Causes some crashes. Not sure when, considering that crashes seemed to increase in 80 presumably due to other code changed to trigger this more often.
• User impact if declined: Crashes.
• Fix Landed on Version: 81
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Should be low risk, because this performs the same operation on principals as before but merely obtains them in a different way in the parent process.
• String or UUID changes made by this patch: None

Comment 13

[Julien Cristau [:jcristau]]

Comment on attachment 9167669 [details]
Bug 1656858 - Obtain principals differently in the parent process in SetFocusInner().

topcrash fix, approved for 80.0b5

Comment 14

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/bf47b69f75ed

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9167669 [details]
Bug 1656858 - Obtain principals differently in the parent process in SetFocusInner().

Approved for 78.2esr.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr78/rev/680f31d4df97