`Uncaught (in promise) Error: not allowed` on about:compat
Categories
(Web Compatibility :: Interventions, defect, P1)
Tracking
(firefox80 unaffected, firefox81 fixed)
| Tracking | Status | |
|---|---|---|
| firefox80 | --- | unaffected |
| firefox81 | --- | fixed |
People
(Reporter: denschub, Assigned: twisniewski)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
In the current nightly, about:compat is empty, showing an exception in the JS console
Uncaught (in promise) Error: not allowed
<anonymous> moz-extension://cd379ded-2d01-a345-ae77-e2bc31021b43/about-compat/aboutCompat.js:49
|
Reporter | |
Comment 1•4 years ago
|
||
This appears to be a regression of bug 1637329! Note that, for some reason, it works fine if you have about:compat loaded at the start (for example by using -a "about:compat" in mozregression, but not if you open a new tab and access the page.
Tom, does something come to mind here?
|
Assignee | |
Comment 2•4 years ago
|
||
No, I'm not sure why that promise would suddenly be failing. But I will have a look tomorrow.
|
|
Reporter | |
Updated•4 years ago
|
|
||
Updated•4 years ago
|
|
|
Assignee | |
Comment 3•4 years ago
|
||
Ah, it turns out that this happens because both the shims and about:compat broker both use browser.runtime.onMessage, and only one of them ends up being called due to both possibly returning a value. The fix isn't too involved - just making sure that both handlers get a chance to process the message, even if one of them returns undefined when it tries to ignore a given message.
|
|
Assignee | |
Comment 4•4 years ago
|
||
Pushed by twisniewski@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bb010698831c ensure that about:compat and shims both get a chance to process messages; r=denschub,webcompat-reviewers
|
||
Comment 6•4 years ago
|
||
| bugherder | ||
Description
•