1656867 - Crash in [@ mozilla::layers::TexTypeForWebgl]

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect, P1)

Description

[Gabriele Svelto [:gsvelto] (PTO)]

This bug is for crash report bp-8c24b1bb-17f4-4409-bc92-11d230200802.

Top 10 frames of crashing thread:

0 XUL mozilla::layers::TexTypeForWebgl gfx/layers/CanvasRenderer.cpp:89
1 XUL mozilla::ClientWebGLContext::OnBeforePaintTransaction dom/canvas/ClientWebGLContext.cpp:328
2 XUL mozilla::layers::BasicCanvasLayer::Paint gfx/layers/basic/BasicCanvasLayer.cpp:36
3 XUL mozilla::layers::BasicLayerManager::PaintSelfOrChildren gfx/layers/basic/BasicLayerManager.cpp:703
4 XUL mozilla::layers::BasicLayerManager::PaintLayer gfx/layers/basic/BasicLayerManager.cpp:870
5 XUL mozilla::layers::BasicLayerManager::EndTransactionInternal gfx/layers/basic/BasicLayerManager.cpp:609
6 XUL mozilla::FrameLayerBuilder::PaintItems layout/painting/FrameLayerBuilder.cpp:7071
7 XUL mozilla::FrameLayerBuilder::DrawPaintedLayer layout/painting/FrameLayerBuilder.cpp:7251
8 XUL mozilla::layers::BasicPaintedLayer::PaintBuffer gfx/layers/basic/BasicPaintedLayer.h:103
9 XUL mozilla::layers::BasicPaintedLayer::Validate gfx/layers/basic/BasicPaintedLayer.cpp:179

This started in buildid 20200728213249, the raw crash reason is MOZ_CRASH(Unexpected LayersBackend::LAYERS_NONE).

Comment 1

[Dzmitry Malyshau [:kvark]]

This seems like it could be an easy fix. Marking as S2 for being a crasher until we know more from Jeff.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

This is currently a Nightly topcrash and will be on Beta next week. Jeff, can you please prioritize a fix for this bug?

Comment 3

[Kelsey Gilbert [:jgilbert]]

On it!

Comment 4

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1656867 - Treat LAYERS_NONE like _BASIC.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ddcc5a21bc86
Treat LAYERS_NONE like _BASIC. r=lsalzman

Comment 6

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/ddcc5a21bc86

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta approval when you get a chance.

Comment 8

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 9171299 [details]
Bug 1656867 - Treat LAYERS_NONE like _BASIC.

Beta/Release Uplift Approval Request

• User impact if declined: Rare MOZ_CRASH in some cases.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Low risk change to handle the case instead of MOZ_CRASHing.
• String changes made/needed: none

Comment 9

[Julien Cristau [:jcristau]]

Comment on attachment 9171299 [details]
Bug 1656867 - Treat LAYERS_NONE like _BASIC.

crash fix, approved for 81.0b3

Comment 10

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/c4132bb4ff67