1656872 - [wpt-sync] Sync PR 24855 - Revert "Updating the putAll implementation to return one request."

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 24855 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/24855
Details from upstream follow.

Sami Kyöstilä <[e-mail]> wrote:

Revert "Updating the putAll implementation to return one request."

This reverts commit 051f139537d02533e0991e5b883aa7c79b96d488.

Reason for revert: Made blink_perf.owp_storage/idb-put{,-all}.html start failing on Android WebView and Pixel 2 perf bots (e.g., https://ci.chromium.org/p/chrome/builders/ci/Android%20Nexus5X%20WebView%20Perf/11775)

Original change's description:

Updating the putAll implementation to return one request.

This change updates the existing putAll implementation to match
the explainer more. It does not yet support the put-all-or-none
behavior, but it does only return one request now.

Design Doc:
https://docs.google.com/document/d/1wawQ8Pl-Vi6GQN5-y2UVkcghipcOGg0WRAC0ZyBkezg/edit#

Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1087927

Change-Id: I2c5e9d2d71801eaab3c1c9e94a3968afb8d109b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310110
Commit-Queue: Numfor Mbiziwo-tiapo \<[e-mail]>
Commit-Queue: Daniel Murphy \<[e-mail]>
Reviewed-by: Daniel Murphy \<[e-mail]>
Reviewed-by: Olivier Yiptong \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#793656}

TBR=[e-mail],[e-mail],[e-mail]

Not skipping CQ checks because original CL landed > 1 day ago.

Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1087927
Change-Id: I6114ae0f3993bcb01754bdc93f25f09056b80504

Reviewed-on: https://chromium-review.googlesource.com/2334956
WPT-Export-Revision: ec8849dea5a0fbb99a6b8d096aa1609cea53e20f

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=ac6f5cd012283c003dd7d5490fa59d66b96f1500

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 1 subtests

Status Summary

Firefox

OK : 2
FAIL: 2

Chrome

OK : 2
PASS: 2

Safari

OK : 2
FAIL: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/IndexedDB/idbobjectstore_putall.tentative.any.html
Data can be successfully inputted into an object store using putAll.: FAIL (Chrome: PASS, Safari: FAIL)
/IndexedDB/idbobjectstore_putall.tentative.any.worker.html
Data can be successfully inputted into an object store using putAll.: FAIL (Chrome: PASS, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a058f157bce4
[wpt PR 24855] - Revert "Updating the putAll implementation to return one request.", a=testonly

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/98781bb6ff4c
[wpt PR 24855] - Revert "Updating the putAll implementation to return one request.", a=testonly

Comment 5

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/98781bb6ff4c